I just added the Location module to a site, and went with the Node Locations method. Upon editing a page, I expected to see fields for entering location info, but they were missing. I would expect them to appear, because on the content type admin page, the default settings under "Locative Information" are
Minimum number of locations: 0
Maximum number of locations: 1
Number of locations that can be added at once: 1
Which implies that location collection should be enabled (but not required) on all existing content types as soon as the module is installed. But these defaults do not take effect -- the location fieldset does not show up on the node edit form -- unless the content type is saved (without making any changes). This behavior is pretty confusing.
I propose that these three "Number of locations" settings be all set to zero by default, since this is the behavior we currently get out of the box, and because if I install Node Locations on a site with a bunch of existing content types, I don't necessarily want to collect location info for all of them. I only want the location fields to appear on node types where I've specifically enabled it. If I make some other changes to a content type, but don't open up the locative info settings fieldset, suddenly the content type will have unintentionally acquired location fields. The same idea applies when adding a new content type-- location fields should not be set to appear by default.
Comment | File | Size | Author |
---|---|---|---|
#2 | location-defaults-1344066-2.patch | 1.15 KB | SeanA |
#1 | location-defaults-1344066.patch | 2.09 KB | SeanA |
Comments
Comment #1
SeanA CreditAttribution: SeanA commentedSimple fix to make the default "Number of locations" settings all zero.
Comment #2
SeanA CreditAttribution: SeanA commentedPlease ignore previous patch, it includes another change from an old issue. Try this one instead.
Comment #3
podarokbot recall
Comment #4
podarokbot
Comment #5
podarok#2 commited pushed to 6.x-3.x-dev
Thanks!