Rss feed 'georss' tag does not validate

This is not added by views.

Perhaps you could search in all files in your installation for "georss". Please file an issue against this module.

Views just uses the core methods here.

I think this qualifies as closed then, no? :)

Same problem here ....

this is the preview of rss feed

plz help me.

<?xml version="1.0" encoding="utf-8" ?>

j

Yep, there is a problem with the location_node rss functionality.
It does not properly set the $node->rss_namespaces.

Can you try this patch and see if it fixes your problem?

Thanks! Worked for me.

I can confirm that patch #7 does ADD the georss namespace... but it also deletes/removes other namespaces.

Testing now to create an updated patch to get both...

So technically this patch solves the issue of adding the georss namespace. However, adding that element to $node->rss_namespaces has the following effect.

<?xml version="1.0" encoding="utf-8" ?><rss version="2.0" xml:base="https://mysite/rss.xml" xmlns:dc="http://purl.org/dc/elements/1.1/" content="http://purl.org/rss/1.0/modules/content/" dc="http://purl.org/dc/terms/" foaf="http://xmlns.com/foaf/0.1/" og="http://ogp.me/ns#" rdfs="http://www.w3.org/2000/01/rdf-schema#" sioc="http://rdfs.org/sioc/ns#" sioct="http://rdfs.org/sioc/types#" skos="http://www.w3.org/2004/02/skos/core#" xsd="http://www.w3.org/2001/XMLSchema#" owl="http://www.w3.org/2002/07/owl#" rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" rss="http://purl.org/rss/1.0/" site="https://mysite/ns#">

goes to

<?xml version="1.0" encoding="utf-8" ?><rss version="2.0" xml:base="https://mysite/events/rss.xml" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:georss="http://www.georss.org/georss">

Printing out the node via dpm shows that prior to this patch, $node->rss_namespaces is empty and adding an element to $node->rss_namespaces causes the other to disappear. I think this might not be an issue with the location module at this point, so I'm willing to mark as RBTC because it seems that this change is really an issue with the node module... and merely a surprising result (at least to me).

Thoughts?

That does seem strange.
In this patch:
+ $node->rss_namespaces += location_rss_namespaces($mode);
In drupal core node_feed() function:

<?php
    // The node gets built and modules add to or modify $node->rss_elements
    // and $node->rss_namespaces.
    $build = node_view($node, 'rss');
    unset($build['#theme']);

    if (!empty($node->rss_namespaces)) {
      $namespaces = array_merge($namespaces, $node->rss_namespaces);
    }
?>

Everything gets merged in so it shouldn't overwrite.

In your example code you have a number of namespaces.
By default in drupal I believe you would only have <rss version="2.0" xml:base="http://d7.rt" xmlns:dc="http://purl.org/dc/elements/1.1/">

Maybe whatever code is inseting your other namespaces is not doing it correctly?
I still don't know how you would end up with the result you got though.

Another possibility I guess is that node_feed() is not what is generating your particular RSS feed?
And whatever is is not doing things right?

I think what happens (at least based on what I'm seeing) is that if NO $node->rss_namespaces are provided, the RDFx module throws in everything... and only when you set a namespace does it revert to just what is needed.

Again, this isn't looking like a location.module issue and it might warrant a new ticket in either Drupal core or RDFa/RDFx. Technically the patch works perfectly, it's just the behavior from other modules/core that is somewhat surprising.

Hi rooby,

I think this is somehow related to a default Drupal behavior instead of anything that this module and/or patch is doing (see my comment in #12).

What would you like me to do in order to test this theory? I could use a different module that adds $node->rss_namespaces and RSS namespace and see if it does the same thing. I actually had the same problem recently using Drupal Gardens in that (by default) they were throwing in all the namespaces even if they were not valid/needed. I think that happens here is that when one is set, it no longer throws in the kitchen sink :)

I'd like to get this tested and committed to the main branch, so let me know what would be sufficient to remove the concerns I brought up in #9/#10?

#1931088: [META] Fixing tests tests were broken, so triggering to active

bot

any updates here
looks like this needs tests due to #1931088: [META] Fixing tests

Sorry I haven't got back to this one for ages.

In theory the patch in #7 should be good.

As rickmanelius mentions, the extra issues are probably a drupal core quirk.
Testing another module that provides rss namespaces to see if the same quirk happens would be a good idea.

Also, location module tests as per #16 would be great to make sure we get what is expected.

#7 commited pushed to 7.x-3.x
thanks!!!

http://drupal.org/node/1942736 tagged in alpha release