Needs review
Project:
LiveChat
Version:
8.x-3.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Nov 2022 at 05:51 UTC
Updated:
21 Jun 2024 at 06:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Naveen Kumar Reddy commentedComment #3
komalparmar commentedComment #5
Manoj Raj.R commentedWorking on some minor fixes and adding Maintainers section.
Comment #7
Manoj Raj.R commentedThis should give proper introduction and maintainers section with proper markdown format.
https://git.drupalcode.org/project/livechat/-/merge_requests/1/diffs
Please review
Comment #9
markie commentedThanks for the merge request. I have committed it and will start a release plan for the next version.
Comment #11
Manoj Raj.R commentedHi @markie
There is new change in the Readme file as per Drupal standard.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...
Updated as per the README.md template.
Please review.
Comment #12
nupur badola commentedGetting warning :
warning: README.md has type 100644, expected 100755
also , few points needs to corrected.
1. Text manually word-wrapped within around 80 cols.
2. Few points are given in table of contents but not explained in details , no section available for them.
Below are the recommended section-
Drupal recommends the following README sections:
Project name and introduction (required)
Table of contents (optional)
Requirements (required)
Recommended modules (optional)
Installation (required, unless a separate INSTALL.md is provided)
Configuration (required)
Troubleshooting & FAQ (optional)
Maintainers (optional)
Comment #14
anjali mehta commentedComment #15
nupur badola commentedStill getting warning of:
warning: README.md has type 100644, expected 100755Comment #17
sakthi_dev commentedPlease review updated the permission.
Comment #18
nupur badola commentedStill getting the same warning:
warning: README.md has type 100644, expected 100755
Comment #19
ravi kant commentedComment #20
ravi kant commentedI have fixed the issues of review report so now review again.
Comment #21
nupur badola commented@ravikant
Still getting the same warning:
warning: README.md has type 100644, expected 100755
Comment #22
ravi kant commented@Nupur Badola
The error is not generating for me.
and patch is applying as designed.
Comment #23
ravi kant commented@Nupur Badola
Lets wait for test by other testers.
Comment #25
silvi.addweb commentedHi, MR 3 applied cleanly
I have fixed below phpcs issue in README.md and committed file. Please review it