Footer message DIV displays when there is no footer message [#1298286]

IMHO, this ought not be, since it makes the footer area 2+ ems taller than it needs to be. I realize this may not get fixed, but perhaps the new maintainer might look at it and consider it.

This line of code in page.tpl.php

<div id="footer-message"><?php if ($footer_message) { ?><?php print $footer_message ?><?php } ?><br /><a href="http://www.roopletheme.com" title="RoopleTheme!"><img src="<?php print base_path() . path_to_theme() . "/roopletheme.png"; ?>" alt="RoopleTheme!"/></a> </div></div>

should be changed to

<?php if (!empty($footer_message)) { ?><div id="footer-message"><?php print $footer_message ?></div><?php } ?>
<div id="roopletheme"><a href="http://www.roopletheme.com" title="RoopleTheme!"><img src="<?php print base_path() . path_to_theme() . "/roopletheme.png"; ?>" alt="RoopleTheme!"/></a></div>

The edit causes the footer_message DIV to be included only if there actually is a footer message. I believe it also removes an extraneous closing DIV. Out of courtesy to the original author, I've kept the RoopleTheme logo, but have placed it in its own DIV. This breaks any custom CSS site developers are using to hide the logo, but that's easily fixed on their end. style.css will also need to be updated to properly style this DIV.

Comments

Comment #1

Kisugi Ai CreditAttribution: Kisugi Ai commented 4 October 2011 at 10:08

Of course I can do that, it has not bother me, that's why I have changed nothing.
It is also still in the Drupal 7 version with the one difference, there you can switch off the logo.
well i think about it but i am not sure if i change it in the Drupal 6 version

Comment #2

mrtoner CreditAttribution: mrtoner commented 19 October 2011 at 15:34

Version:

6.x-1.7

» 6.x-1.x-dev

I really wish you would change it, so I don't have to keep hacking the theme. Again, the two issues are:

- The footer_message DIV appears even if there is no footer message set in the site information

- The RoopleTheme logo is set in the footer_message DIV, so that the logo can't be hidden (via CSS) without also hiding any footer message

Here is what's needed to fix both:

<div id="footer">
  <?php if ($footer_region): ?>
    <div id="footer-region">
      <?php print $footer_region?>
    </div>
  <?php endif; ?>
  <?php if ($footer_message) { ?>
  <div id="footer-message">
    <?php print $footer_message ?>
  </div>
  <?php } ?>
  <div id="roople" style="text-align: center;"><a href="http://www.roopletheme.com" title="RoopleTheme!"><img src="<?php print base_path() . path_to_theme() . "/roopletheme.png"; ?>" alt="RoopleTheme!"/></a></div>
</div>