This patch replaces theme_list_formatter_comma with a Twig template.

CommentFileSizeAuthor
#7 2942617-6.patch4.01 KBjunaidpv
#6 2942617_list_formatter_comma_5.patch4.04 KBbrunodbo
#4 2942617_list_formatter_comma_4.patch4.04 KBbrunodbo
#2 2942617_list_formatter_comma_1.patch3.97 KBbrunodbo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

brunodbo created an issue. See original summary.

brunodbo’s picture

brunodbo
he/him
CreditAttribution: brunodbo at Textillia commented
Issue summary: View changes
FileSize
2942617_list_formatter_comma_1.patch3.97 KB
brunodbo’s picture

brunodbo
he/him
CreditAttribution: brunodbo at Textillia commented
Status: Active » Needs review
brunodbo’s picture

brunodbo
he/him
CreditAttribution: brunodbo at Textillia commented
FileSize
2942617_list_formatter_comma_4.patch4.04 KB

This uses the formatter settings directly in the template, since we don't need the whole $formatter in there. (Note that this patch is now dependent on the patch in #2942348: Allow 'List' field formatter to be used in view mode configuration).

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented

Minor but you don't need a space before {{ attributes }}

brunodbo’s picture

brunodbo
he/him
CreditAttribution: brunodbo at Textillia commented
FileSize
2942617_list_formatter_comma_5.patch4.04 KB

Removed the space before {{ attributes }}.

junaidpv’s picture

junaidpv
Location Kannur, Kerala
CreditAttribution: junaidpv at Detlus for Wickwood Marketing commented
FileSize
2942617-6.patch4.01 KB

Re-rolled for current branch.

Maks Oleksyuk’s picture

Maks Oleksyuk CreditAttribution: Maks Oleksyuk as a volunteer commented
Related issues: +#3336999: Convert theme function to twig template.