After inserting a link in CKEditor 5, attempting to type text before or after the link creates a new element with no href attribute.
Insert a link using linkit.
Place the cursor directly before or after the link and start typing. The text turns blue, but doesn't go anywhere when you click on it. I can usually, but not always, reproduce this issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | 3364963-this-link-has-no-url-18.patch | 17.04 KB | drpldrp |
| #16 | 3364963-this-link-has-no-url-16.patch | 14.87 KB | trackleft2 |
| linkit2.gif | 222.92 KB | bgreco |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
mark_fullmerThanks for the GIF illustrating the problem. I've encountered this problem, too. I assume it has to do with CKEditor 5's upcasted version of the element having a greedy boundary.
Setting the priority to "Major," as this could cause headaches for content editors.
Comment #3
mark_fullmerUpdate: this is still considered a "Major" level bug for Linkit, and is still prioritized.
Comment #6
trackleft2Comment #7
trackleft2The issue is present, even with the patch applied.
Comment #8
trackleft2FYI https://ckeditor.com/docs/ckeditor5/latest/features/link.html#typing-aro...
Comment #9
trackleft2Comment #10
trackleft2Comment #12
acbramley commented#10 fixes it but it completely breaks linkit functionality, data attributes are missing entirely.
Comment #15
edwardsay commentedThis issue was partially resolved in Drupal Core 10.2 because it uses CKEditor version 40.
After the update, there is no "This link has no URL" tooltip when clicking on the end of the link. But it is still present when clicking on the start of the link.
Comment #16
trackleft2Updated the MR and added a new patch against 6.1.x
Comment #18
drpldrp commentedCkEditor does special link handling if the element attribute data model name starts with "link", eg. "linkHref" or "linkWhatever".
LinkIt uses
['data-entity-type', 'data-entity-uuid', 'data-entity-substitution']for both the attribute model and view names.So because the model names don't start with "link", CkEditor thinks it should inherit the previous element attributes like for bold or other styling.
The fix is to split out the attribute vars so the model names start with "link" and the view names stay the same.
Attached patch tested with Drupal 10.1.8 and LinkIt 6.1.3.
Comment #19
drpldrp commentedMarking as Needs Review. Sorry if this is not the appropriate workflow, ie. this is missing tests, requires MR, or anything else.
Comment #24
mark_fullmerThe explanation for the root cause, provided in #18, makes sense to me, above, and the code change looks valid. Tests pass, so let's merge this!
Comment #25
acbramley commentedAmazing, thanks everyone! And thanks a lot @mark_fullmer for including this in a release already :)