Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The 6.0.x version of the module is already compatible with Drupal 10. You should use 6.0.x for Drupal 10. Patches posted to this issue are only intended for temporary workarounds to simplify the update process.
Problem/Motivation
Make the 8.x-5.x version of this module D10-compatible to simplify the update process for people upgrading to Drupal 10
Proposed resolution
Mega patch from here or split this into individuals for:
- The "core/jquery.ui.autocomplete" asset library is deprecated
- Deprecated file stuff (constants, file_* functions)
- PHPUnit deprecations
- finally, info.yml/composer
Comment | File | Size | Author |
---|---|---|---|
#21 | 3292870-drupal-10-readiness.patch | 28.02 KB | edmund.dunn |
Issue fork linkit-3292870
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mglamanComment #3
mglamanComment #5
mglamanComment #6
heddnCan we get a D10 tagged release? I dislike using dev branches.
Comment #7
mglamanComment #8
hudriAccording to their drupal.org profile pages, both module maintainers aren't active anymore in this community.
(@johnwebdev has written it on his profile page that he is no longer working with Drupal, and in case of @anon this is my assumption because I have not found any contribution credit or release within the last two years).
Maybe someone volunteers maintaining this really exceptional module?
Comment #9
Andrew.Macpherson CreditAttribution: Andrew.Macpherson commentedNew maintainers would be wonderful, but I'm afraid I can be of no help at all with this: I simply don't have the skills/knowledge.
I agree that this is an exceptional module … in fact, I've often wished they would move it to core (although I also appreciate there may be good reasons why that shouldn't happen). I reckon there are probably a lot of sites that are waiting for this module to be made compatible with Drupal 10 so they can upgrade
Comment #10
laura.gatesPatch applied successfully to 9.5.x and 6.0.0 -beta3 and upgrade status now says "no problems found."
Comment #11
mark_fullmerWith #3317769: Drastically improve the linking experience in CKEditor 5 on the way in Drupal core, I think maintainership could be limited to getting this D10 and CKEditor-5 compatible so as not to prevent sites from updating to D10 while the core solution for linking is in progress. I sent a message to johnwebdev, with whom I've worked in the past on other contrib modules, but have not yet heard back. I have therefore opened a maintainership request in https://www.drupal.org/project/linkit/issues/3338953, as the next step in transfer outlined by https://www.drupal.org/project/projectownership/
Feedback request
I think it might make sense, concurrent with the D10-compatible release of this module, to mark its lifecycle as "deprecated" per https://www.drupal.org/node/3215042 and point to the core issue. That will help people starting new D10 sites to consider waiting to add LinkIt in favor of the upcoming core solution, and will help existing sites transfer to it. Thoughts?
Comment #12
mark_fullmerUpdate on the status of a new release for Linkit: https://www.drupal.org/project/linkit/issues/3338953#comment-14908817
Comment #13
Andrew.Macpherson CreditAttribution: Andrew.Macpherson commentedHi Mark, I'm not sure if Linkit should be marked as deprecated, although I admit I may not fully understand what that implies. If I correctly (even though quickly) read the discussion about the improvements in Drupal core, they're not thinking about a full-featured replacement and there are several really important use cases where the proposed solution seems to be to "use the contrib Linkit module". So it seems they might be thinking that the two will sit alongside each other, perhaps?
Comment #14
mark_fullmerHi Andrew,
That's a completely valid point: the only circumstance under which we could mark LinkIt as "deprecated" (meaning, it has a replacement with feature parity and/or superiority) is if the Drupal core solution did, in fact, provide feature parity.
I agree that use case that you call out in #3317769: Drastically improve the linking experience in CKEditor 5 -- the ability to specify whether certain media entity bundles should link directly to the media item or to the entity's "page" -- is critical. If it doesn't end up in core, LinkIt should live on.
Comment #15
smustgrave CreditAttribution: smustgrave at Mobomo commentedWonder if we can get a release for D10? Know the ckeditor5 stuff is still ongoing but consensus I've heard is people will upgrade to D10 before ckeditor5 since so many plugins are still in progress.
Comment #16
mark_fullmerPending the resolution of #3338953: Offering to co-maintain LinkIt, I plan to make a D10-compatible release, yes, and that's not dependent on having CKEditor 5 support, since folks can use this module with the (now contrib) CKEditor 4 module.
Comment #17
smustgrave CreditAttribution: smustgrave at Mobomo commentedTried testing this out but now seems linkits are breaking
I see this error in the console
Uncaught ReferenceError: item is not defined
Comment #18
mark_fullmerI think there may be some outdatedness in this issue! Here's my understanding of where this ended up:
We could conclude, then:
Does that sound right to everyone?
Comment #19
smustgrave CreditAttribution: smustgrave at Mobomo commentedIs there a way to get a 6.x d10 release then? Even if ckeditor5 is still in progress? Using a dev branch is something we try to avoid on a number of projects
Comment #20
mark_fullmerYep! As stated above, pending resolution of #3338953: Offering to co-maintain LinkIt a new release will be issued: 6.0.0-beta4.
Comment #21
edmund.dunn CreditAttribution: edmund.dunn at Agile Six Applications for Department of Veterans Affairs commentedPosting a static patch because merge requests don't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC
Comment #22
mark_fullmerJust a housekeeping update on this issue for D10 compatibility for the 8.x-5.x branch: A D10-compatible release of the 6.0.x branch, 6.0.0-beta4, was released on 5 March 2023.
What I could use help with, as a maintainer, is information about whether there is a reason that there still needs to be a D10-compatible release for the 8.x-5.x branch. For example, are there any open issues with patches specific to the 8.x-5.x branch people are depending on which don't have 6.0.x equivalents?
If we can provide feature parity in the 6.0.x branch and not make the update from 8.x-5.x onerous, that would be preferable than providing D10 (and CKEditor 5) compatibility for two branches.
Thanks in advance for community input!
Comment #23
agoradesign CreditAttribution: agoradesign commentedHi Mark,
I don't think so, that full D10 compatibility is needed in 5.x branch.
I'd go even further and question, if there's any good reason to further maintain the 5.x branch (besides some kind of emergency updates)? Because the 6.x branch is not D10 only, but also for 9.4 und 9.5 -> any older Drupal core version is no longer maintained, so you could be strict here too. I'd prefer, if you don't waste any of your valuable time on maintaining old branches
Comment #24
Greg BoggsComment #25
Greg BoggsI have clarified the current status for D10 support in the issue title and description.
Comment #26
mark_fullmerComment #27
mark_fullmer