Hello project maintainers,

Creating this issue to help make this module compatible with Drupal 10.

CommentFileSizeAuthor
#4 Add field.jpg56.95 KBchandra gowsalya kannan
#4 Drupal 10 upgrade status.jpg16.69 KBchandra gowsalya kannan
#4 Functionality-D9.jpg51.23 KBchandra gowsalya kannan
#4 D10 Functionality.png28.12 KBchandra gowsalya kannan
#3 drupal-check.txt2.81 KBrahul17
#3 linked_entity_reference_d10-3358368-3.patch2.88 KBrahul17

Issue fork linked_entity_reference-3358368

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rahul17 created an issue. See original summary.

rahul17’s picture

rahul17 commented
Assigned: Unassigned » rahul17
Status: Active » Needs work
rahul17’s picture

rahul17 commented
Status: Needs work » Needs review
StatusFileSize
new linked_entity_reference_d10-3358368-3.patch2.88 KB
new drupal-check.txt2.81 KB

Created patch to makes this module D10 compatible and resolve below issue :

The website encountered an unexpected error. Please try again later.
Error: Class "Drupal\media_library\Plugin\Field\FieldWidget\MediaLibraryWidget" not found in include() (line 24 of modules\contrib\linked_entity_reference\src\Plugin\Field\FieldWidget\LinkedMediaLibrary.php).

Kindly review it.

chandra gowsalya kannan’s picture

chandra gowsalya kannan commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new D10 Functionality.png28.12 KB
new Functionality-D9.jpg51.23 KB
new Drupal 10 upgrade status.jpg16.69 KB
new Add field.jpg56.95 KB

Tested patch in Drupal 9 and Drupal 10. Patch is applied successfully and no non ignorable errors in drupal check.
Functionality is working in both D9.5.7 and D10.0.3 with php 8.1. Attached screenshot for reference.

Moving this to RTBC !

Eduardo Morales Alberti made their first commit to this issue’s fork.

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented

We need to update this module to be compatible with drupal 10, the problem is, that until is not merged, we should use a fork because the patch with the compatibility applies after composer resolves the dependencies.
We will open a fork, to be able to use this module on drupal 10 until the patch is merged.

Eduardo Morales Alberti opened merge request !2

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented

Using drupal upgrade status we got the following message after the analysis:

Class Drupal\linked_entity_reference\Plugin\Field\FieldWidget\LinkedMediaLibrary extends @internal class Drupal\media_library\Plugin\Field\FieldWidget\MediaLibraryWidget.
eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented

Maybe the core classes should not be internal https://www.drupal.org/project/drowl_layouts/issues/3350603
We think this is an error that can be ignored by now.

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented
Assigned: rahul17 » Unassigned

Reviewed, module installs properly and seems to work.

Detected #3411215: "There are no content items matching" when trying to add a second value in a multivalued field but this bug is present prior to this update, so not blocking for this.

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.