Problem/Motivation

The parent entity relationship provided by the Dynamic Entity Reference module was removed https://www.drupal.org/project/linkchecker/issues/3375553

Steps to reproduce

Try to add a relationship to a Linkchecker View. Notice there are no longer any options.

Proposed resolution

Apply the patch attached to this ticket. It implements a hook to add the parent entity relationship.
All credit for the patch should be given to user rp7 and was pulled from this post: https://www.drupal.org/project/linkchecker/issues/3375553#comment-16105877

CommentFileSizeAuthor
#2 linkchecker-parent-relationship-FIXED.patch1.89 KBlee.cocklin
linkchecker-parent-relationship.patch1.84 KBlee.cocklin

Issue fork linkchecker-3539894

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lee.cocklin created an issue. See original summary.

lee.cocklin’s picture

lee.cocklin commented
StatusFileSize
new linkchecker-parent-relationship-FIXED.patch1.89 KB

joseph.olstad made their first commit to this issue’s fork.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Ok, that patch was not made from a clone of linkchecker , it was made from someones drupal repo. Cleaned it up (including some phpcs fixes) and preparing a merge request.

joseph.olstad opened merge request !122

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Patch from #2 has unexpected paths.

Here's the linkchecker diff that most people are looking for.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

phpcs is green, phpunit tests are also passing

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@lee.cocklin, thanks for creating this issue and for the patch. I made changes as mentioned (phpcs fixes and rebase to linkchecker instead of your Drupal project) and created a merge request which triggers the pipeline.

Everything shows up green in the pipeline.

patrickharris made their first commit to this issue’s fork.

patrickharris’s picture

patrickharris commented

@joseph.olstad I've added a commit to support all entities, not just nodes. See if you think it might be useful.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Version: 2.0.2 » 2.0.x-dev
Status: Needs review » Reviewed & tested by the community

The code looks good and works. Tested on the 2.0.2 version. Thank you!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Why 2.0.x-dev ? Has anyone tested this with 2.1.x? when upgrading to 2.1.x , use composer to bring in dynamic_entity_reference in order to uninstall it, since it's no longer needed with 2.1.x however catch 22, you need it to uninstall it so a bit of a manual step for the upgrade but highly recommend it.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

MR was for 2.1, not 2.0 as stated in the issue.
Please rebase and test.
Please provide test results.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Fixed » Needs work
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Version: 2.0.x-dev » 2.1.x-dev
Status: Needs work » Needs review

I personally have not tested this.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Version: 2.1.x-dev » 2.0.x-dev

joseph.olstad opened merge request !130

joseph.olstad closed merge request !122

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Patch from MR 130

FYI: I am not using this patch, nor do I endorse it.

My teams and clients prefer the 2.1.x builds, not 2.0.x

brianbrarian’s picture

brianbrarian commented

Is there a patch available for 2.1.x?

EDIT: Never mind, the "FIXED" patch in #2 appears to work with 2.1.0.