Add option to disable cron activity

+1, Would really like to skip link checking for local development.

You could install Ultimate Cron, then disable the individual linkchecker cron task

Would be great to have a simple test for this as well, before we commit it

I've tested this just now and it works as expected. Not setting it to RTBC as for outstanding test coverage.

I agree that we should increase test coverage. But in this case I think we don't need an extra test: "if disabled it's truly not running at cron".

In any case it would be helpful if there is a merge request for this change.

Added changes from #4 to a MR

It works. Just wondering, should a message be logged when cron link checking is skipped?

> should a message be logged when cron link checking is skipped?

I don't think so. Especially on functionality like linkchecker I like to control this directly with own cron jobs without extra modules. So this logging if someone like to add should also get an own config to disable.

I can confirm that the patch is working.
On the other hand, I can also recommend to install Ultimate Cron module, which provides an easy UI to schedule each module's cron run differently, e.g. linkchecker only once or several times in the night. No patch needed in that scenario.

Thanks for your contribution.
Can we update the it to the latest branch?

Also, the settings form in 2.x had an error, so I fixed that here as well.

https://git.drupalcode.org/project/linkchecker/-/merge_requests/75/diffs...

If you want to merge it earlier than this issue, you can fix it here:

#3463362: Linkchecker settings form error

hook_update for new config property?

I've rebased the MR!75

Thanks @solideogloria. Looks like you did commit to old branch.
Outstanding tasks

• MR 75 need hook_update from MR 49
• Remove gitignore

Rebased MR.

I still think .gitignore should be added, as Drupal recommends DDEV for contributing, and DDEV adds all those files. It's helpful to ensure they don't get accidentally added to the project. I removed it as you requested.

I also added the missing update hook

Just left a comment in the MR

Looks like the changes in LinkExtracto‎rService.php‎ and LinkcheckerLinkPa‎geEntityLabel.php‎ are unrelated to this issue and should be removed from the MR, I guess?

I've rebased MR !75 for 2.0.x and I've created MR !129 for 2.1.x

Thanks, I just ran into the same issue and tried MR !129. LGTM and works like a charm.

Still this has "Needs tests", so if that's still valid, this needs (final) work. Just to be totally sure: besides Cron, linkchecker currently can only be run manually, right? There's nothing else hidden (like check on node save, etc.) that could cause it to run? Otherwise we should also add a setting for that.

As Drupal 8+ has no way to "disable" modules, just uninstalling it, this option totally makes sense!

Edit:
The answer is NO, it has further effects! See #3581562: Add option to disable Linkchecker (esp. entity hooks)

It also has Drush commands that run it, which could be run from CLI.

Thanks @solideogloria yes, but that's at least triggered manually. More risky is the hidden hook functionality, see #35 and the issue description in #3581562: Add option to disable Linkchecker (esp. entity hooks)

This is exactly what I'm after

I don't think states is needed to hide anything - disable cron still allows us to use drush so we want all items visible - not sure it is important enough to elevate, I think people will find it if they are looking for it.

Adding a minimal test - test only job just shows schema errors so not very useful, but everything else is green

Thanks @ericgsmith. I think besides this #3581562: Add option to disable Linkchecker (esp. entity hooks) is (even more) important. Thanks for the test!

I scanned through the code changes and the comment @anybody left about the UI. I think the UI and states thing doesn't need to hold this up and would recommend @anybody or anybody to create a follow-up if they feel strongly about the position of the field.

The code looks clean, no notes, let's merge and move forward.

Position is fine for me, if it's fine for you and the maintainers. Don't think worth a follow-up. If anyone likes to, move it :)