Cron task does not impersonate to admin user on automatic content updates

It is quite a hard issue to explain really. But what basicly happens is if a cron job is run by the system then any page with a link that is getting updated by link checker because it was recorded as "moved permanently" loses any extra information like which Taxonomy it belonged to. It also does not actually create a revision of this updated page which makes it hard to see what changes link checker actually made to the page.

user 1 has full admin permission on everything. The same as my user. If I run the cron myself manually then it works. I get a new revision and I get the correct taxonomy. but if I let it run by cron itself then both of those do not happen.

In my site Anonymous users are not allowed to edit pages so that may be where the issue comes.
You may need to remove all permissions from Anonymous to replicate the issue. Infact the site has no anonymous accessibility at all.

I think you are right about the issue being permission and it is probably in the effect that this does need to be run as admin user as opposed to anonymous.

I have actually managed to fix it using the link to safely impersonating another user.

I will do a patch and submit it for testing.

That shouldn't be too hard. Just need to add the field to the admin page for selecting the user and have it so that if a user is selected in there then that is the user to add in the function _linkchecker_status_handling which is where I placed the user fix.

function _linkchecker_status_handling($link, $response) {
global $user;
$original_user = $user;
$old_state = session_save_session();
session_save_session(FALSE);
$user = user_load(1);
 
Lots and lots of lines of code (Entire content of the function)


  $user = $original_user;
session_save_session($old_state);
}

Then have it that where it uses $user= user_load(1) that the 1 can be the value for the user in that field. The only issue with it is that a user can be impersonated without any authentication what so ever which is not a good thing. But I think that is more a drupal issue then a link checker one ;).

Yeah the location that I placed the impersonation only affects the after effects of the check. So when an action must be performed.

I have found one more problem now. It appears that it is not actually doing the changes. Merely creating the revision and adding a comment to it. But not actually changing the link. I have to look at it further.

I will work on testing the D6 a little more and creating a patch for this.

I am attaching my patch that I did for now that does not fully work but allows impersonating a user so maybe if anyone else wants to test as well and see where it is going wrong they can.

I am guessing that the problem may be that is loses it's impersonation when it changes functions. So we may need to impersonate multiple times. But I will test and let you know.

Adding it to sub functions did not help. Need to work out why it is not editing the nodes.

Not sure if it is related or not.

Yeah I noticed the unrelated changes. Have no idea how that happens when I just downloaded the copy I compared to and made no changes to those files. Will try and rectify and yes UI option is the next step. Just wasn't sure about the function because my links do not change. ;)

Ok so obviously once this is finished I will need all links to be able to be updated so I am thinking that it may end up as my next task unless something is already happening on it? :D

Yes it sounds like a good idea.

And then work on the local links. Because that is where my biggest issue is seeing as my site in an Intranet so majority of linking is internal. :) With 1500 pages having been created and still active in 1 year of it being live and about 1000 documents linked to the pages it means there is a lot of links flying around. :D. And at present 95% of all broken / moved links are internal. :)

BTW for me it is both External and Internal links that are not changing. Not sure why.

I am not sure I understand the problem.

Is it not possible to just change the text in question with the correct Alias. I mean if there is a redirection to the correct page and the system has been able to determine this should this not just be a case of swapping the information.

Or am I not understanding something?

Like for example if I change the alias and a redirection is created by the Path redirect module then shouldn't it just be able to change any reference to the old link to the new link?

So I have done a dump now and the before and after end up the same. Going to investigate why.

Ok now I am done testing. I found out the issue. The pages I was testing with were missing the a tag. The link was because the text was a https:// and it automatically was creating the link which linkchecker found but did not change because of the fact the link was in the main body text not a tag.... It should be possible to make this change also though?