I have a project that requires BLT 8.9.12, Drupal 8.4, Lighting 2.2.7, which builds and patches with no issues. But when I require drupal/core:"8.5.0-alpha1" and acquia/lightning:"3.1.x-dev" the project builds, but then composer uninstalls core and what appears to be every module that has a patch. The composer build stops after the core patch fails, so core is installed, but the patched contrib modules are missing from /docroot/modules/contrib. I tried adding the patches to the root composer file's patches-ignore but that did not change anything.

I need to upgrade the site to 8.5 because I need to run the wbm2cm migration process, which fails on this site in 8.4, see https://www.drupal.org/project/lightning/issues/2939611.

Here is my composer file:


{
  "name": "test/agency",
  "description": "Test Agency Site.",
  "type": "project",
  "license": "proprietary",
  "minimum-stability": "dev",
  "prefer-stable": true,
  "require": {
    "acquia/blt": "^8.9.12",
    "acquia/lightning": "3.1.x-dev",
    "geerlingguy/drupal-vm": "^4.7",
    "cweagans/composer-patches": "~1.0",
    "drupal/address": "^1.1",
    "drupal/admin_toolbar": "^1.21",
    "drupal/coffee": "^1.0",
    "drupal/bootstrap": "^3.7",
    "drupal/bootstrap_paragraphs": "^2.0",
    "drupal/ckeditor_bootstrap_buttons": "^1.1",
    "drupal/core": "8.5.0-alpha1",
    "drupal/dynamic_entity_reference": "^1.4",
    "drupal/entity_reference_revisions": "^1.3",
    "drupal/geolocation": "^1.1",
    "drupal/menu_link_attributes": "^1.0",
    "drupal/media_entity_actions": "^1.0",
    "drupal/migrate_source_csv": "^2.0",
    "drupal/migrate_tools": "^4.0",
    "drupal/module_filter": "^3.0",
    "drupal/paragraphs": "^1.1",
    "drupal/redirect": "^1.0",
    "drupal/social_media_links": "^2.5",
    "drupal/superfish": "^1.1",
    "drupal/migrate_plus": "^4.0",
    "drupal/console": "^1.0",
    "drupal/calendar": "1.x-dev",
    "drupal/editor_file": "^1.2",
    "drupal/views_infinite_scroll": "^1.5",
    "drupal/editor_advanced_link": "^1.4",
    "drupal/oauth2_client": "^1.0",
    "drupal/views_bootstrap": "^3.0",
    "drupal/classy_paragraphs": "^1.0",
    "drupal/simple_oauth": "^3.0",
    "drupal/backup_migrate": "^4.0",
    "drupal/webform": "5.x-dev",
    "drupal/better_exposed_filters": "^3.0",
    "drupal/responsive_menu": "2.x-dev",
    "drupal/fontyourface": "^3.1",
    "drupal/contact_formatter": "^1.0"
  },
  "require-dev": {
    "drupal/examples": "1.x-dev"
  },
  "extra": {
    "enable-patching": true,
    "installer-paths": {
      "docroot/core": [
        "type:drupal-core"
      ],
      "docroot/modules/contrib/{$name}": [
        "type:drupal-module"
      ],
      "docroot/modules/custom/{$name}": [
        "type:drupal-custom-module"
      ],
      "docroot/profiles/contrib/{$name}": [
        "type:drupal-profile"
      ],
      "docroot/profiles/custom/{$name}": [
        "type:drupal-custom-profile"
      ],
      "docroot/themes/contrib/{$name}": [
        "type:drupal-theme"
      ],
      "docroot/themes/custom/{$name}": [
        "type:drupal-custom-theme"
      ],
      "docroot/libraries/{$name}": [
        "type:drupal-library",
        "type:bower-asset",
        "type:npm-asset"
      ],
      "drush/contrib/{$name}": [
        "type:drupal-drush"
      ]
    },
    "merge-plugin": {
      "require": [
        "vendor/acquia/blt/composer.required.json",
        "vendor/acquia/blt/composer.suggested.json"
      ],
      "include": [
        "blt/composer.overrides.json"
      ],
      "merge-extra": true,
      "merge-extra-deep": true,
      "merge-scripts": true,
      "replace": false,
      "ignore-duplicates": true
    },
    "patches": {
    },
    "installer-types": [
      "bower-asset",
      "npm-asset"
    ]
  },
  "repositories": {
    "drupal": {
      "type": "composer",
      "url": "https://packages.drupal.org/8"
    },
    "assetpackagist": {
      "type": "composer",
      "url": "https://asset-packagist.org"
    }
  }
}

Here is the composer install output:


> composer install

[Removed regular package building output generated prior to lock file write.]

Writing lock file
Generating autoload files
Gathering patches for root package.
Removing package drupal/core so that it can be re-installed and re-patched.
- Removing drupal/core (8.5.0-alpha1)
Deleting docroot/core - deleted
Removing package drupal/crop so that it can be re-installed and re-patched.
- Removing drupal/crop (2.0.0-beta1)
Deleting docroot/modules/contrib/crop - deleted
Removing package drupal/entity_block so that it can be re-installed and re-patched.
- Removing drupal/entity_block (1.0.0-alpha2)
Deleting docroot/modules/contrib/entity_block - deleted
Removing package drupal/entity_browser so that it can be re-installed and re-patched.
- Removing drupal/entity_browser (2.0.0-alpha2)
Deleting docroot/modules/contrib/entity_browser - deleted
Removing package drupal/entity_embed so that it can be re-installed and re-patched.
- Removing drupal/entity_embed (1.0.0-beta2)
Deleting docroot/modules/contrib/entity_embed - deleted
Removing package drupal/media_entity_instagram so that it can be re-installed and re-patched.
- Removing drupal/media_entity_instagram (2.0.0-alpha1)
Deleting docroot/modules/contrib/media_entity_instagram - deleted
Removing package drupal/panelizer so that it can be re-installed and re-patched.
- Removing drupal/panelizer (4.0.0)
Deleting docroot/modules/contrib/panelizer - deleted
Removing package drupal/panels so that it can be re-installed and re-patched.
- Removing drupal/panels (4.2.0)
Deleting docroot/modules/contrib/panels - deleted
Removing package drupal/simple_oauth so that it can be re-installed and re-patched.
- Removing drupal/simple_oauth (3.3.0)
Deleting docroot/modules/contrib/simple_oauth - deleted
Removing package drupal/workbench_moderation so that it can be re-installed and re-patched.
- Removing drupal/workbench_moderation (1.2.0)
Deleting docroot/modules/contrib/workbench_moderation - deleted
Loading composer repositories with package information
Updating dependencies (including require-dev)
1/38: https://codeload.github.com/minkphp/MinkBrowserKitDriver/legacy.zip/10e67fb4a295efcd62ea0bf16025a85ea19534fb
2/38: https://codeload.github.com/FriendsOfPHP/Goutte/legacy.zip/395f61d7c2e15a813839769553a4de16fa3b3c96
3/38: https://codeload.github.com/Textalk/websocket-php/legacy.zip/bfa18bb6bf523680c7803f6b04694fbbf2f67bbf
4/38: https://codeload.github.com/minkphp/MinkGoutteDriver/legacy.zip/8b9ad6d2d95bc70b840d15323365f52fcdaea6ca
5/38: https://codeload.github.com/minkphp/MinkSelenium2Driver/legacy.zip/473a9f3ebe0c134ee1e623ce8a9c852832020288
6/38: https://codeload.github.com/symfony/browser-kit/legacy.zip/490f27762705c8489bd042fe3e9377a191dba9b4
7/38: https://codeload.github.com/mikey179/vfsStream/legacy.zip/d5fec95f541d4d71c4823bb5e30cf9b9e5b96145
8/38: https://codeload.github.com/instaclick/php-webdriver/legacy.zip/6fa959452e774dcaed543faad3a9d1a37d803327
9/38: https://codeload.github.com/jhedstrom/DrupalDriver/legacy.zip/aa1f32b207939dfc0c96919be47b952d3c1b900b
10/38: https://codeload.github.com/Behat/MinkExtension/legacy.zip/badc565b7a1d05c4a4bf49c789045bcf7af6c6de
11/38: https://codeload.github.com/elvetemedve/behat-screenshot/legacy.zip/1e2f704a5dd26b679953d6aff9a1add7ec978f81
12/38: https://codeload.github.com/tkotosz/behat-extension-driver-locator/legacy.zip/af9fb11f5f3cc220ee2c08071ee9d50f11048b86
13/38: https://ftp.drupal.org/files/projects/shield-8.x-1.1.zip
14/38: https://codeload.github.com/minkphp/Mink/legacy.zip/e6930b9c74693dff7f4e58577e1b1743399f3ff9
15/38: https://ftp.drupal.org/files/projects/seckit-8.x-1.0-alpha2.zip
16/38: https://ftp.drupal.org/files/projects/memcache-8.x-2.0-alpha5.zip
17/38: https://ftp.drupal.org/files/projects/qa_accounts-8.x-1.0-alpha1.zip
18/38: https://ftp.drupal.org/files/projects/config_split-8.x-1.3.zip
19/38: https://ftp.drupal.org/files/projects/config_filter-8.x-1.1.zip
20/38: https://ftp.drupal.org/files/projects/acquia_purge-8.x-1.0-beta3.zip
21/38: https://gitlab.com/api/v4/projects/DMore%2Fbehat-chrome-extension/repository/archive.zip
22/38: https://ftp.drupal.org/files/projects/config_update-8.x-1.5.zip
23/38: https://ftp.drupal.org/files/projects/devel-8.x-1.2.zip
24/38: https://ftp.drupal.org/files/projects/features-8.x-3.5.zip
25/38: https://codeload.github.com/symfony/stopwatch/legacy.zip/c865551df7c17e63fc1f09f763db04387f91ae4d
26/38: https://gitlab.com/api/v4/projects/DMore%2Fchrome-mink-driver/repository/archive.zip
27/38: https://codeload.github.com/phpDocumentor/ReflectionDocBlock/legacy.zip/e6a969a640b00d8daa3c66518b0405fb41ae0c4b
28/38: https://codeload.github.com/jakoch/phantomjs-installer/legacy.zip/4d0e994f110a79738b73083c2c3086d162547bd6
29/38: https://ftp.drupal.org/files/projects/cog-8.x-1.13.zip
30/38: https://codeload.github.com/sensiolabs-de/deprecation-detector/legacy.zip/2a878df49d4d9f54e0f9b758ce26d2e2c7d0cff8
31/38: https://codeload.github.com/Behat/Transliterator/legacy.zip/826ce7e9c2a6664c0d1f381cbb38b1fb80a7ee2c
32/38: https://codeload.github.com/nikic/PHP-Parser/legacy.zip/f78af2c9c86107aa1a34cd1dbb5bbe9eeb0d9f51
33/38: https://codeload.github.com/Behat/Gherkin/legacy.zip/74ac03d52c5e23ad8abd5c5cce4ab0e8dc1b530a
34/38: https://codeload.github.com/j-arnaiz/behat-junit-formatter/legacy.zip/2f80b3881e04d3cf43e05ab821c0e80675a9846d
35/38: https://ftp.drupal.org/files/projects/purge-8.x-3.0-beta8.zip
36/38: https://codeload.github.com/Behat/Behat/legacy.zip/44a58c1480d6144b2dc2c2bf02b9cef73c83840d
37/38: https://codeload.github.com/jhedstrom/drupalextension/legacy.zip/50ff0f413f0dc4732f49638e743f86f45e835e50
38/38: https://codeload.github.com/sveneisenschmidt/selenium-server-standalone/legacy.zip/ef4eea9c99efb9c0e3084e9cae625662ccd43361
Finished: success: 38, skipped: 0, failure: 0, total: 38
Package operations: 51 installs, 2 updates, 2 removals
- Removing phpdocumentor/type-resolver (0.4.0)
- Removing phpdocumentor/reflection-common (1.0.1)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
- Installing behat/transliterator (v1.2.0): Loading from cache
- Installing behat/gherkin (v4.5.1): Loading from cache
- Installing behat/behat (v3.3.1): Loading from cache
- Installing jarnaiz/behat-junit-formatter (v1.3.2): Loading from cache
- Installing jakoch/phantomjs-installer (2.1.1-p07): Loading from cache
- Installing symfony/stopwatch (v3.4.4): Loading from cache
- Updating phpdocumentor/reflection-docblock (4.3.0 => 2.0.5): Loading from cache
- Updating nikic/php-parser (v3.1.4 => v1.4.1): Loading from cache
- Installing sensiolabs-de/deprecation-detector (0.1.0-alpha4): Loading from cache
- Installing drupal/core (8.5.0-alpha1): Loading from cache
- Applying patches for drupal/core
https://www.drupal.org/files/issues/2752961-90.patch (Clear Twig caches on deploys)
https://www.drupal.org/files/issues/1356276-408--8.4.4.patch (1356276 - Allow profiles to provide a base/parent profile and load them in the correct order)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/1356276-408--8.4.4.patch

[Exception]
Cannot apply patch 1356276 - Allow profiles to provide a base/parent profile and load them in the correct order (https://www.drupal.org/files/issues/1356276-408--8.4.4.patch)!

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [
]...

Comments

captaindav created an issue. See original summary.

balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented

Unfortunately, there are known patch failures on the 3.1.x branch of Lightning. See #2939509: Provide a branch for testing core 8.5.x.

I'm not sure what the solution is, but if you want to help, re-rolling the patches listed in that issue would be a good start.

Another approach might be to figure out exactly what issues that are committed to 8.5.x you need. Then bring those in as patches to your build.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented

Hey @balasama I found this issue because it appears that I am having problems specifically with the patch:
https://www.drupal.org/files/issues/2752961-90.patch (Clear Twig caches on deploys)

That wasn't a patch that was tested on 8.4 (only 8.1) and a much more recent patch exists. I'm going to open a new issue to get that one updated because I think it's breaking my build.

balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
Status: Active » Closed (duplicate)

I think this is a dup of #2939509: Provide a branch for testing core 8.5.x