Drupal core 8.4.3 was just released. Unfortunately, this patch provided by Lightning no longer applies cleanly:
https://www.drupal.org/files/issues/1356276-408--8.4.x.patch

This produces errors on any composer-based build of a Lightning project that tries to upgrade to 8.4.3.

Long-term, it might be better for Lightning to pin core to a specific version as long as it's being patched, even though this limits the flexibility of downstream projects somewhat.

CommentFileSizeAuthor
#2 1356276-408--8.4.3.patch66.59 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dane Powell created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
FileSize
1356276-408--8.4.3.patch66.59 KB

Okay. Here's a reroll against HEAD of 8.4.x, as of today.

balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
Status: Needs review » Postponed
Related issues: +#2929211: Packagist seems unaware of the 8.4.3 tag

Currently blocked on https://www.drupal.org/project/drupal/issues/2929211

balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
Status: Postponed » Needs review

https://github.com/acquia/lightning/pull/535

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. RTBC once the tests pass on Pipelines and Travis CI.

sylus’s picture

sylus CreditAttribution: sylus commented

I also had this problem, and solved it by pinning on sub profile to 8.4.2.

balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
Status: Reviewed & tested by the community » Fixed

Fixed in cd52b8c3a6fdf8ae97d5ae626f527c6896bb0b50

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

BXMurphy’s picture

BXMurphy CreditAttribution: BXMurphy commented

I get this error, too, when I issue composer create-project --no-interaction acquia/blt-project my-project.

I've been doing pretty good... Drupal, Drupal VM, VirtualBox, Vagrant, Ubuntu WSL with reverse-mount shares. I even nailed a Triple Lutz (Russian judge gave me an 8.2).

And all I wanted was a nice website that I could maintain some PHP and MySQL pages in. I didn't even get a t-shirt.

How is this fixed? Somebody said, "Fixed in cd52b8c3a6fdf8ae97d5ae626f527c6896bb0b50." I don't get it.

I'm trying to do jgeerling's thing at https://www.jeffgeerling.com/blog/2017/set-blt-and-drupal-vm-entirely-wi...

I went to the Forum for help but I don't see a search function to look for an answer. Can someone point me in the right direction? Is this a Composer issue? A "well, you really can't run Drupal on a Windows box" thing? Please help. I'd hate to admit defeat and be boxed in by Wordpress yet again.

Sorry for venting..

casc-or’s picture

casc-or CreditAttribution: casc-or as a volunteer commented

BXMurphy, you're not the only one - I'm following the exact path you are and got the same error this morning (but not yesterday).

If I find a solution/workaround I'll message.

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented

@BXMurphy and @casc-or, it's hard to say for sure since you didn't post any clear error messages or output from composer install, but based on the timing I expect you are actually hitting a new version of this bug.

This bug applied to Drupal core 8.4.3. If you check your composer output, it's probably trying to install 8.4.4.

The Lightning team is aware of this problem, I think this is the right issue to follow: #2934239: Update to core 8.4.4

As a workaround, you should be able to pin your version of Drupal core to 8.4.3 in your own composer.json.

casc-or’s picture

casc-or CreditAttribution: casc-or as a volunteer commented

Note that this is a BLT install.

Composer command

composer create-project --no-interaction acquia/blt-project casc-blt

Composer output excerpt

Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 112 installs, 2 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.

[...snip...]

  - Installing drupal/core (8.4.4): Downloading (100%)
  - Applying patches for drupal/core
    https://www.drupal.org/files/issues/2752961-90.patch (Clear Twig caches on deploys)
    https://www.drupal.org/files/issues/1356276-408--8.4.3.patch (1356276 - Allow profiles to provide a base/parent profile and load them in the correct order)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/1356276-408--8.4.3.patch

                                                                                                                        
  [Exception]                                                                                                           
  Cannot apply patch 1356276 - Allow profiles to provide a base/parent profile and load them in the correct order (https://www.drupal.org/files/issues/1356276-408--8.4.3.patch)!
                                                                                                                        

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

[ExecStack]  Exit code 1  Time 08:30
[error]  Could not install Composer requirements.
techwolf12’s picture

techwolf12 CreditAttribution: techwolf12 at Unc Inc commented

This could happen because of the docroot folder. Composer patches has a pull request for this: https://github.com/cweagans/composer-patches/pull/204

:)