Problem/Motivation

Before a stable release we should make sure that our theme passes Drupal coding standards
http://pareview.sh/pareview/httpgitdrupalorgprojectlightskeletongit

Solution
We need to fix all pareview.sh warning/errors.

CommentFileSizeAuthor
#7 2576715-Drupal_Coding_Standards-7.patch41.7 KBanabpv
#5 code_standard_fixes-2576715-5.patch40.12 KBchishah92

Issue fork light_skeleton-2576715

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

darol100 created an issue. See original summary.

moymilo’s picture

moymilo CreditAttribution: moymilo at FFW commented

How I can help with this?

darol100’s picture

darol100 CreditAttribution: darol100 as a volunteer and commented

For D7 theming, the easier way is to run Coder/Auto-format. This will fix most is the formatting/minor issue. To also keep fixing those issue we need to use https://www.drupal.org/project/pareviewsh to see what error are left after you run the auto-formart.

Feel free to work on it.

chishah92’s picture

chishah92 CreditAttribution: chishah92 at Blisstering Solutions commented
Assigned: Unassigned » chishah92
chishah92’s picture

chishah92 CreditAttribution: chishah92 at Blisstering Solutions commented
Version: 7.x-1.x-dev » 8.x-1.0
Status: Active » Needs review
FileSize
code_standard_fixes-2576715-5.patch40.12 KB

I have fixed the code standard issues according to the PAReview.sh resolving all codesniffer issues

anabpv’s picture

anabpv
she/her
Location Portugal 🇵🇹
CreditAttribution: anabpv at CI&T commented
Assigned: chishah92 » anabpv

Since this issue needs review, I will review it.

anabpv’s picture

anabpv
she/her
Location Portugal 🇵🇹
CreditAttribution: anabpv at CI&T commented
Assigned: anabpv » Unassigned
FileSize
2576715-Drupal_Coding_Standards-7.patch41.7 KB

I have applied the fixes from Code Sniffer and Code Beautify. All issues have been resolved.
Needs to be reviewed to confirm the fix.

tmaiochi’s picture

tmaiochi CreditAttribution: tmaiochi at CI&T commented
Assigned: Unassigned » tmaiochi

I'll review this.

tmaiochi’s picture

tmaiochi CreditAttribution: tmaiochi at CI&T commented
Assigned: tmaiochi » Unassigned
Status: Needs review » Reviewed & tested by the community

Steps performed:
(1) Installed module
(2) Reproduced the issue.
(3) Applied patch.
(4) Code review on changes.
(5) Tested again with patch, issue resolved.
The patch fixed all warnings and errors. There's no PHPCS messages and the theme worked normally.