We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation

CommentFileSizeAuthor
#20 Libraries_readme.PNG32.62 KBkavitha89
#15 Libraries_Readme.md31.12 KBkavitha89
#14 Before.png290.8 KBrinku jacob 13
#14 After.png304.29 KBrinku jacob 13
#12 3319622-12.patch2.3 KBshubham rathore
#2 3319622-2.patch1.48 KBkomalparmar

Issue fork libraries-3319622

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

komalparmar created an issue. See original summary.

komalparmar’s picture

komalparmar commented
StatusFileSize
new 3319622-2.patch1.48 KB
komalparmar’s picture

komalparmar commented
Status: Active » Needs review

I have changed readme.txt file into readme.md.
Please review it.

komalparmar’s picture

komalparmar commented
Assigned: Unassigned » komalparmar
Nila Hyalij’s picture

Nila Hyalij commented
Status: Needs review » Reviewed & tested by the community

patch #2 seems to be good for me.
Moving to RTBC.

ressa opened merge request !6

ressa closed merge request !6

ressa made their first commit to this issue’s fork.

ressa opened merge request !7

ressa’s picture

ressa
he/him
commented
Status: Reviewed & tested by the community » Needs review

@komalparmar and @Nila Hyalij:

Applying the patch just deletes the file, as far as I can tell ... did either one of you test the patch after uploading it, or changing Status to "Reviewed & tested by the community"?

I have created a new README.md file, the MR can be previewed at https://git.drupalcode.org/issue/libraries-3319622/-/tree/3319622-switch....

shubham rathore’s picture

shubham rathore commented
Title: Replace README.txt with README.md » Replace README.txt with README.md and update README.md file
Assigned: komalparmar » shubham rathore
Status: Needs review » Needs work
shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3319622-12.patch2.3 KB

Hi please review this ptach.

ressa’s picture

ressa
he/him
commented

@Shubham Rathore: There is a patch up for review and MR already in Gitlab. If anything, please review it, in stead of uploading another patch manually:

https://git.drupalcode.org/project/libraries/-/merge_requests/7

rinku jacob 13’s picture

rinku jacob 13 commented
StatusFileSize
new After.png304.29 KB
new Before.png290.8 KB

Hi @ressa , I have successfully reviewed your merge request !7 for drupal version 10.0.2. Adding screenshots for the reference. Need +1 RTBC

kavitha89’s picture

kavitha89 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Libraries_Readme.md31.12 KB

The patch works fine. Moving it to RTBC

shiv_sharma’s picture

shiv_sharma commented
Status: Reviewed & tested by the community » Needs work

please take reference from this url https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review

Please review.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
kavitha89’s picture

kavitha89 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Libraries_readme.PNG32.62 KB

The patch works fine and moving it to RTBC.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.