Problem/Motivation

I saw a @todo tag that I though I could help with.

Steps to reproduce

See line 66 in libraries/src/Plugin/libraries/Type/PhpFileLibraryType.php

Proposed resolution

Create a way to check which libraries were already loaded in the code and use this to prevent the code from loading these libraries again.

Remaining tasks

Review patch

CommentFileSizeAuthor
#2 3256978-2.patch1.29 KBandregp

Issue fork libraries-3256978

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andregp created an issue. See original summary.

andregp’s picture

andregp commented
Assigned: andregp » Unassigned
Status: Active » Needs review
StatusFileSize
new 3256978-2.patch1.29 KB

I hope this patch fix the issue.

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: Unassigned » beatrizrodrigues

I'll do the review

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: beatrizrodrigues » Unassigned
Status: Needs review » Reviewed & tested by the community

Patch seems good to me.

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora opened merge request !13

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Thanks CI&T team

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.