Problem/Motivation

I was looking into things I could help with on this module and found this @todo tag I could work with on LocalRemoteAssetTrait.php

Steps to reproduce

go to libraries/src/ExternalLibrary/Asset/LocalRemoteAssetTrait.php and check the line 54:
@todo Throw an exception.

Proposed resolution

Add a throw new \Exception with an appropriate error message.

Remaining tasks

Review the patch.

CommentFileSizeAuthor
#2 3256961-2.patch1.23 KBandregp

Issue fork libraries-3256961

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andregp created an issue. See original summary.

andregp’s picture

andregp commented
Assigned: andregp » Unassigned
Status: Active » Needs review
StatusFileSize
new 3256961-2.patch1.23 KB

Here is the patch.
I added a throw exception (and also fixed a small typo on the same function).

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi
tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned
Status: Needs review » Reviewed & tested by the community

Steps performed:
(1) Installed module
(2) Reproduced the issue.
(3) Applied patch.
(4) Code review on changes.
The patch added correctly a throw exception.
(5) Tested again with patch, issue resolved.

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora opened merge request !17

  • joseph.olstad committed 43c51fb0 on 8.x-3.x authored by andregp 
    Issue #3256961 by urvashi_vora, andregp, tmaiochi: Throw an exception on...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Look great thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.