Problem/Motivation

Looking for some things to work on the code I found a simple @todo tag that I could work with.

Steps to reproduce

Open libraries/src/ExternalLibrary/LibraryManager.php and check @todo tag on line 115.
@todo Validate that the type is a string.

Proposed resolution

Add a validation to check the type.

Remaining tasks

Review patch.

CommentFileSizeAuthor
#2 3256949-2.patch846 bytesandregp

Issue fork libraries-3256949

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andregp created an issue. See original summary.

andregp’s picture

andregp commented
Assigned: andregp » Unassigned
Status: Active » Needs review
StatusFileSize
new 3256949-2.patch846 bytes

Here is the patch

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi
tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned
Status: Needs review » Reviewed & tested by the community

Steps performed:
(1) Installed module
(2) Reproduced the issue.
(3) Applied patch.
(4) Code review on changes.
The patch checks correctly if type is a string.
(5) Tested again with patch, issue resolved.

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora opened merge request !18

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.