Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.It would be handy if we can get the automated tests passing again so that patch submissions still trigger the d.o. testbots. Of course comprehensive updates to (or removal of) old tests will be needed once the architectural changes for 8.x-3.x are more clear, but for now I was just thinking about quick fixes that can get the testbots to turn green once again. I think this would include:
- Skipping any simpletest test methods in LibrariesWebTest that depend on libraries_load() given that we know this logic must be replaced by integration with core Library support.
- Fixing any syntax errors in the new test coverage added in #2090623: Turn hardcoded library_load_files() into a more modern, flexible system (I'm seeing at least one failure there).
I'm not sure what will happen with the simpletest cases, but keeping the related classes in place is probably best for now.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | libraries_testbot-quick-fix-2593003-2.patch | 1.88 KB | rjacobs |
| |||
Comments
Comment #2
rjacobs CreditAttribution: rjacobs at Center for Research Libraries commentedThe attached should work. It "voids" out two test methods in LibrariesWebTest and eliminates an erroneous @covers statement for Drupal\Tests\libraries\Kernel\ExternalLibrary\PhpFile\PhpFileLibraryTest::testPhpFileLibrary().
Again, this is just meant as a quick fix. This is a pretty minor low-risk thing, but I'll wait to commit until tomorrow in case there's a comment.
Comment #3
rjacobs CreditAttribution: rjacobs at Center for Research Libraries commentedHere's the patch referred to in #2.
Comment #5
rjacobs CreditAttribution: rjacobs at Center for Research Libraries commentedPatch committed, but there is still one test failure that I need to figure out.
Comment #7
tstoecklerThanks, wasn't aware of this, but just fixed the problem I think you're describing with http://drupalcode.org/project/libraries.git/commit/0b9e2d3
Marking fixed as at the time of writing https://www.drupal.org/pift-ci-job/55375 is green.
Thanks!
Comment #8
rjacobs CreditAttribution: rjacobs at Center for Research Libraries commentedInteresting, thanks for getting that (I think it might have taken me a while to figure that out). It's puzzling that everything was passing on my local instance even before that commit you referenced. Anyway, it's great to see that the bots are happy now.
Comment #9
tstoecklerYeah, I always use the PhpUnit test runner when testing things locally, not run-tests.sh. I think run-tests.sh would have thrown the failure, but I didn't test it, I was just blindly guessing :-)