libraries.module on line 83
libraries.module on line 136

I'm not familiar enough with the new D8 code to determine if these can safely be commented out for now or not.

CommentFileSizeAuthor
#2 libraries-conf_path-2579283-2.patch1.03 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

r0nn1ef created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Priority: Normal » Critical
Status: Active » Needs review
FileSize
libraries-conf_path-2579283-2.patch1.03 KB
r0nn1ef’s picture

r0nn1ef CreditAttribution: r0nn1ef commented

I have applied the patch in #2 and no longer receive the previous errors. Thanks for the quick turn around on this!

rjacobs’s picture

rjacobs CreditAttribution: rjacobs commented

The patch seems consistent with #2384675: Deprecate conf_path() and the relevant change record.

-  $config = conf_path();
+  $config = DrupalKernel::findSitePath(\Drupal::request());

Just curious, will getting the request via \Drupal::request() cause any problems if library detection needs to happen via a non-http request? I suppose that the logic in question (libraries_get_libraries() and libraries_scan_info_files()) only make sense to use during a normal Drupal page request, but I just wanted to confirm that I understand the request management details correctly for this scope.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. @rjacobs do you want to pull the trigger? ;-)

  • rjacobs committed b5fea24 on 8.x-3.x authored by Berdir 
    Issue #2579283 by Berdir, r0nn1ef: Call to undefined function conf_path...
rjacobs’s picture

rjacobs CreditAttribution: rjacobs commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Contributed project blocker

Sounds good to me. Committed.

I also removed that tag that I think only really applies to core queues.

Status: Fixed » Needs work

The last submitted patch, 2: libraries-conf_path-2579283-2.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.