Problem/Motivation

module_invoke call in libraries.module is outdated and cause fatal errors.

Proposed resolution

Replace with \Drupal::moduleHandler()->invoke()

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 replace_module_invoke-2427801-1.patch663 bytesAnushka-mp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anushka-mp’s picture

Anushka-mp CreditAttribution: Anushka-mp commented
Status: Active » Needs review
FileSize
replace_module_invoke-2427801-1.patch663 bytes

Status: Needs review » Needs work

The last submitted patch, 1: replace_module_invoke-2427801-1.patch, failed testing.

Anushka-mp’s picture

Anushka-mp CreditAttribution: Anushka-mp commented
Status: Needs work » Needs review

The test failures are existing ones.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Would be nice to get this in, the remaining test failures are only related to _drupal_add_js/css, and fixing this makes it work again at least for our use case, which is jwplayer, see #2425153: Add test coverage.

  • tstoeckler committed ea03e01 on 8.x-3.x authored by Anushka-mp 
    Issue #2427801 by Anushka-mp, tstoeckler: Replace module_invoke() call.
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot!

Committed this. I did a minor modification to save $module_handler in a variable.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.