Currently we check if (variable_get('less_devel', FALSE) && user_access('access administration pages')) { but I don't think the user_access() is needed here. Is this for a reason?

CommentFileSizeAuthor
#2 debug-mode.patch671 bytesamitaibu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

corey.aufang’s picture

corey.aufang CreditAttribution: corey.aufang commented
Status: Active » Closed (works as designed)

I felt that the nature of the message was such that only administrators should see it.

I wouldn't want the message to show if I accidentally had developer mode enabled on a live website.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Status: Closed (works as designed) » Needs review
FileSize
debug-mode.patch671 bytes

Oh, no, I mean about file_unmanaged_delete_recursive($less_path); not being executed for non-privileged users. The message of course should be permission based.

Patch attached.

corey.aufang’s picture

corey.aufang CreditAttribution: corey.aufang commented
Status: Needs review » Fixed

Indeed you are right.

I had made the change in the D6 version but forgot to make it here.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented

Thanks -- next time please don't forget to credit in the commit log ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.