With drupal 8.3.0-alpha1 'Leaflet map' views style option window displays:

Please add at least one geofield to the view.

If disable condition in line 174 of /leaflet_views/src/Plugin/views/style/LeafletMap.php:
if (is_a($handler, '\Drupal\views\Plugin\views\field\Field')) {
geofield list is back.

CommentFileSizeAuthor
#11 2852506-11.patch913 bytesTim Bozeman
#10 interdiff-5-10.txt1.37 KBmarcoscano
#10 2852506-10.patch922 bytesmarcoscano
#5 leaflet_map-no_field_recognized-2852506-5.patch1.37 KBmadar
leaflet_map-views_style_option-disable_handler_check.patch1.21 KBmadar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

madar created an issue. See original summary.

madar’s picture

madar CreditAttribution: madar as a volunteer commented
Title: No field recognized in "Leaflet map" views style settings in 8.3.0-alpha1 » No field recognized in 'Leaflet map' views style settings in 8.3.0-alpha1
Issue summary: View changes
friera’s picture

friera CreditAttribution: friera as a volunteer commented

It works for me!

abrakadobr’s picture

abrakadobr CreditAttribution: abrakadobr commented

i confirm problem, and confirm patch with addon:

if ($field_storage_definition) { //i've got error "null has no method getType"                                                                                                                        
  if ($field_storage_definition->getType() == 'geofield' || strpos($label,'wkt') !== false) {                                                             
    $fields_geo_data[$field_id] = $label;                                                                                                                 
  }                                                                                                                                                       
}
madar’s picture

madar CreditAttribution: madar as a volunteer commented
FileSize
leaflet_map-no_field_recognized-2852506-5.patch1.37 KB

Abrakadobr solution works for me on 8.3.0. Here is a patch with code from #4.

nottaken’s picture

nottaken CreditAttribution: nottaken commented

#5 patch worked for me.

ipwa’s picture

ipwa CreditAttribution: ipwa commented

I can now choose the geofield but when trying to view the map I get an error.

waspper’s picture

waspper CreditAttribution: waspper as a volunteer and at Skilld commented

Patch provided in #5 made my Views map style -- Leaflet (Old) -- to work nicely.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Status: Active » Needs review

Hello,

I applied the patch from #5 and it solved the problem thanks.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano at Lullabot commented
FileSize
2852506-10.patch922 bytes
interdiff-5-10.txt1.37 KB

I don't think the approach in #5 is the safest one.

If we just use the correct class we can keep the first conditional. The patch attached solves the problem for me.

Tim Bozeman’s picture

Tim Bozeman CreditAttribution: Tim Bozeman at CyberSolution for Sagetree commented
FileSize
2852506-11.patch913 bytes

Rerolling #10 which seems to be doing the job.

polynya’s picture

polynya CreditAttribution: polynya at Edo commented

Patch #10 is working correctly. Patch #11 cannot be applied to 8.x-1.x branch.

ckaotik’s picture

ckaotik
Primary language German
Location Berlin
CreditAttribution: ckaotik at werk21 commented

Patch in #10 works like a charm and applies cleanly to the 8.x-1.x dev branch.

The patch in #11 only applies to 8.x-1.0-beta1, but not to the current dev release. That code was changed on 2016-10-11.

ckaotik’s picture

ckaotik
Primary language German
Location Berlin
CreditAttribution: ckaotik at werk21 commented
Status: Needs review » Closed (duplicate)

Just realized that this is a duplicate of #2839538: LeafletMarker could not recognize geofield. That issue has an RTBC patch, so let's go with that instead.