Attached patch try to detect if '$feat['icon']['iconUrl']' is a Drupal relative path, if yes, attach the site base_path()

CommentFileSizeAuthor
#6 leaflet-detect_relative_iconurl-2157851-6.patch845 bytesjenlampton
#5 leaflet-detect_relative_url_marker-2157851-5.patch690 bytesPerignon
#1 leaflet-relative-path-relative-url-2157851-1.patch1.47 KBpaolomainardi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented
FileSize
leaflet-relative-path-relative-url-2157851-1.patch1.47 KB
revagomes’s picture

revagomes CreditAttribution: revagomes commented

+1

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented

up

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented

Feedback ?

Perignon’s picture

Perignon CreditAttribution: Perignon commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +base_path
FileSize
leaflet-detect_relative_url_marker-2157851-5.patch690 bytes

This needed to be rerolled against the current dev. There was a release on this module last month.

I also cleaned up the patch to only address the issue here. There were some formatting changes in the first page.

Putting to RTBC as this works and I made no changes to the code from the first patch.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton at Jeneration Web Development for UC Berkeley - Archaeological Research Facility commented
Status: Reviewed & tested by the community » Needs review
FileSize
leaflet-detect_relative_iconurl-2157851-6.patch845 bytes

After entering a relative URL for the marker icon /sites/default/files/marker.svg this patch made my markers disappear, as it added a second leading slash to the URL for the image: //sites/default/files/marker.svg.

I've rerolled the patch to check if both base_url() and a relative path include a leading slash, and if so, not include them both.