The new short array syntax doesn't work on older versions of PHP (which I have).

Can we keep D7 using the short array syntax please?

I've attached a patch

CommentFileSizeAuthor
#2 2955394-2-long-aray-syntax.patch7.83 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 2955394-2-long-aray-syntax.patch7.83 KB
grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Needs review » Closed (won't fix)

Hi

PHP 5.3 has been EOL for over three years. Making any effort to support it is grossly negligent from my perspective and I cannot support such a patch. Also, as INSTALL.txt makes clear, 5.6 is the minimum requirement for this module.

Sorry.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Closed (won't fix) » Active

Well that's unfortunate... can you set the PHP version requirements in the info file to indicate this?

https://www.drupal.org/docs/7/creating-custom-modules/writing-module-inf...

Edit: Drupal 7 is intended to work with >= 5.2 unless you as a maintainer decide otherwise. https://www.drupal.org/docs/7/system-requirements/drupal-7-php-requirements, so I'm just asking for explicit break

  • grahl committed d9a5db7 on 7.x-2.x authored by joelpittet 
    Issue #2955394 by joelpittet: Short Array Syntax doesn't work for older...
grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Active » Closed (won't fix)

Fair enough, I've added a php declaration in ldap_servers.info to force at least 5.4. I've chosen not to enforce 5.6 due to the number of existing 5.4 and 5.5 systems, even though I strongly recommend against it. I will not spend my time supporting any EOL version, though 5.4 and 5.5 should in theory still be backwards compatible enough.

Please also note that the requirements page you are linking to clearly states that 5.4 is the minimum recommended version for D7.