Problem/Motivation

Drupal\lb_default_blocks\Plugin\Block\DefaultBlock::getPosition() can return NULL if the layout position has been deleted

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3270038-pass.patch3.8 KBlarowlan
#5 3270038-fail.patch1.77 KBlarowlan
#4 3246150-pass.patch4.05 KBlarowlan
#4 3246150-fail.patch3.36 KBlarowlan
#2 3270038.patch2.03 KBlarowlan

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new 3270038.patch2.03 KB

This is technically a BC break so will make this a 2.x branch

mohit_aghera’s picture

mohit_aghera commented

Code looks good.
I think it would be great to have kernel tests.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3246150-fail.patch3.36 KB
new 3246150-pass.patch4.05 KB

Good idea

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3270038-fail.patch1.77 KB
new 3270038-pass.patch3.8 KB

Ga wrong files

The last submitted patch, 5: 3270038-fail.patch, failed testing. View results

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
mohit_aghera’s picture

mohit_aghera commented
Status: Needs review » Reviewed & tested by the community

Looks good and working as expected!

  • larowlan committed 1ebf06d on 1.x 
    Issue #3270038 by larowlan, mohit_aghera: Drupal\lb_default_blocks\...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.