Call to a member function getValue() on null in lazy_preprocess_field [#3268604]

Problem/Motivation

Lazy is throwing the following fatal error on pages where the preprocessor is run, on an item that is not an (Media) Entity Reference.
Call to a member function getValue() on null in lazy_preprocess_field

Steps to reproduce

Enable the module and create a field with Lazy Loading enabled.
Now enter a SVG in that field, that is saved as an URL instead of a Media Item/Reference

Proposed resolution

We should check if the `#item` key in the preprocessor is available.
If not, we can assume that no target_id is available, so we can skip the processing.

Remaining tasks

Add an extra condition before using any #item values, like in the patch.

Comment	File	Size	Author
#9	3268604-9.patch	829 bytes	staalex
#7	lazy_preprocess_field.patch	1.17 KB	jeffc518
#2	extra-item-condition.patch	908 bytes	dennisdk
	extra-item-condition.patch	1.7 KB	dennisdk

Issue fork lazy-3268604

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3268604-call-to-a changes, plain diff MR !27
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

9 March 2022 at 14:16

dennisdk created an issue. See original summary.

Comment #2

dennisdk

Dutch

commented 9 March 2022 at 14:23

Status	File	Size
new	extra-item-condition.patch	908 bytes

Comment #3

dennisdk

Dutch

commented 9 March 2022 at 14:23

1 file was hidden/shown/deleted

Status	File	Size
hidden	extra-item-condition.patch	1.7 KB

Comment #4

dennisdk

Dutch

commented 9 March 2022 at 14:26

Issue summary:

View changes

Comment #5

ndf commented 9 March 2022 at 14:48

Status:

Active

» Reviewed & tested by the community

We encounter this problem, because a custom image-processor is returning a render array without a referenced image, but with a plain uri instead.
Then additionally the lazy module allows to configure 'lazy load' on the field-display level.

IMO the patch is needed, because this lazy module should validate its input before further processing.

And if the input is not ok, it should fail silently.
Without this patch, it throws an unhandled exception. Which is inappropriate if a malformed image cannot be lazy-loaded.

But with this patch, the plain uri image is rendered, but not lazy loaded.

Comment #6

jeffc518 commented 7 April 2022 at 16:14

I'm running into the exact same issue but with a "Remote Video" Media entity. Right before the error, it throws up a notice first:

Notice: Undefined index: #item in lazy_preprocess_field() (line 162 of /code/web/modules/contrib/lazy/lazy.module)

Why does the patch create a new .module file though?

diff --git a/lazy.module b/lazy_new.module
index 6e23418df..aaf356422 100644
--- a/lazy.module
+++ b/lazy_new.module

Comment #7

jeffc518 commented 7 April 2022 at 16:34

Status	File	Size
new	lazy_preprocess_field.patch	1.17 KB

Rerolled patch to overwrite existing lazy.module (nested web root needed)

Comment #8

timme77 commented 11 April 2022 at 11:52

patch #7 works for me. thx!

Comment #9

staalex commented 28 February 2023 at 09:40

Status:

Reviewed & tested by the community

» Needs review

Status	File	Size
new	3268604-9.patch	829 bytes

Patch #7 works but it doesn't fix the initial problem. The problem appears when you are trying to lazy load SVGs. This can work if the SVGs are wrapped in an <img> tag, but with this patch, they will simply be ignored. It's better to use $element['#items'] to load the file ID, which is the same even when we have ['#markup'] instead of the expected render array for files.