This is a followup to #3244237-8: Use correct dependency notation in layout_builder_restrictions_by_region.info.yml

Problem/Motivation

Currently a composer.json file is missing, which causes dependency errors in tests for MRs.

Related documentation:

Steps to reproduce

  • Create issue fork / MR with arbitrary changes and see tests failing due to unresolved dependencies

Proposed resolution

  • Add composer.json file with required (dev-)dependencies

Remaining tasks

  • Create issue fork / MR with proposed resolution

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork layout_builder_restrictions-3244465

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hctom created an issue. See original summary.

hctom’s picture

hctom
Primary language German
CreditAttribution: hctom at undpaul commented
Issue summary: View changes
gabrielda’s picture

gabrielda
He/Him
CreditAttribution: gabrielda at CI&T commented
Assigned: Unassigned » gabrielda

Hello,

I will work on this issue today.

gabrielda opened merge request !6

gabrielda closed merge request !6

gabrielda reopened merge request !6

gabrielda’s picture

gabrielda
He/Him
CreditAttribution: gabrielda at CI&T commented

Still working on it.

gabrielda’s picture

gabrielda
He/Him
CreditAttribution: gabrielda at CI&T commented
Assigned: gabrielda » Unassigned
Status: Active » Needs review

Hello! Kindly review the added composer.json files.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Assigned: Unassigned » paulocs
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Assigned: paulocs » Unassigned
Status: Needs review » Needs work

Just made a review.

gabrielda’s picture

gabrielda
He/Him
CreditAttribution: gabrielda at CI&T commented
Assigned: Unassigned » gabrielda
Status: Needs work » Active

Working on the changes appointed.

gabrielda’s picture

gabrielda
He/Him
CreditAttribution: gabrielda at CI&T commented
Assigned: gabrielda » Unassigned
Status: Active » Needs review

Worked on the appointed fixes. Please review it. Thanks.

gabrielda’s picture

gabrielda
He/Him
CreditAttribution: gabrielda at CI&T commented
Assigned: Unassigned » gabrielda
Status: Needs review » Needs work

Fixing identation

gabrielda’s picture

gabrielda
He/Him
CreditAttribution: gabrielda at CI&T commented
Assigned: gabrielda » Unassigned
Status: Needs work » Needs review

Fixed identation, please review once again. Thank you!

gabrielda’s picture

gabrielda
He/Him
CreditAttribution: gabrielda at CI&T commented
Assigned: Unassigned » gabrielda
Status: Needs review » Needs work

One more fix to go.

gabrielda’s picture

gabrielda
He/Him
CreditAttribution: gabrielda at CI&T commented
Assigned: gabrielda » Unassigned
Status: Needs work » Needs review

Fixed identation on line 38. Please review. Thanks!

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs review » Reviewed & tested by the community

Thanks @gabrielda. It looks good now and the tests can be properly triggered via GitLab.

Moving to RTBC.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer at University of Texas at Austin commented
Status: Reviewed & tested by the community » Fixed

  • mark_fullmer committed 15beab3 on 8.x-2.x 
    Issue #3244465 by gabrielda, hctom, paulocs, mark_fullmer: Add composer....
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer at University of Texas at Austin commented

Thanks! I just updated the maintainers list in the staged composer.json to match what's in the README. Everything else looks good.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.