FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\layout_builder_modal\src\Form\LayoutBuilderModalSettingsForm.php
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
66 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
67 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#11 3370984-After.png209.43 KBkushagra.goyal
#11 3370984-Before.png81.63 KBkushagra.goyal
#10 3370984-10.patch4.24 KBelber
#8 3370984-8.patch4.24 KBchaitanyadessai
#6 interdiff_4-6.txt1.1 KBmrinalini9
#6 dependency-injection-fixed-6.patch3.11 KBmrinalini9
#4 interdiff_2-4.txt2.75 KBurvashi_vora
#4 dependency-injection-fixed.patch2.43 KBurvashi_vora
#2 3370984-2.patch2.26 KBarti_parmar

Issue fork layout_builder_modal-3370984

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

arti_parmar created an issue. See original summary.

arti_parmar’s picture

arti_parmar commented
Assigned: arti_parmar » Unassigned
Status: Active » Needs review
StatusFileSize
new 3370984-2.patch2.26 KB

Kindly review patch.

Status: Needs review » Needs work

The last submitted patch, 2: 3370984-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

urvashi_vora’s picture

urvashi_vora commented
Status: Needs work » Needs review
Issue tags: +Dependency Injection (DI)
StatusFileSize
new dependency-injection-fixed.patch2.43 KB
new interdiff_2-4.txt2.75 KB

Providing another patch and an interdiff.

Please review.

Thanks

Status: Needs review » Needs work

The last submitted patch, 4: dependency-injection-fixed.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new dependency-injection-fixed-6.patch3.11 KB
new interdiff_4-6.txt1.1 KB

Fixing test case failure issues in #4, please review it.

Thanks & Regards,
Mrinalini

Status: Needs review » Needs work

The last submitted patch, 6: dependency-injection-fixed-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

chaitanyadessai’s picture

chaitanyadessai commented
Status: Needs work » Needs review
StatusFileSize
new 3370984-8.patch4.24 KB

Adding patch, Please review.

Status: Needs review » Needs work

The last submitted patch, 8: 3370984-8.patch, failed testing. View results

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs work » Needs review
StatusFileSize
new 3370984-10.patch4.24 KB
kushagra.goyal’s picture

kushagra.goyal commented
StatusFileSize
new 3370984-Before.png81.63 KB
new 3370984-After.png209.43 KB

Hi @elber, Thanks for patch. I have applied the patch and tested on local it is resolving the issue. Hence +1 RTBC...

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs review » Reviewed & tested by the community

Hi moving to RTBC based in the previously comment