The summary::marker does not display when the element is set to display:block (see https://github.com/timarney/react-faq/issues/29). This is coming from the #layout-builder-modal summary CSS provided by Layout Builder Modal.
Have a summary showing up in Layout Builder Modal with the Seven theme (not Bartik, which is the default) using FF, and the caret will be missing
Add a polished version of the sugested change at https://www.drupal.org/project/drupal/issues/2886904#comment-12568251:
@-moz-document url-prefix() {
#layout-builder-modal summary {
display: list-item;
}
}
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Edit_layout_for_Flex_page___UT_Drupal_Kit.png | 539.45 KB | lreynaga |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
mark_fullmerThanks for the report and the proposed fix, lreynaga!
I can confirm that I can reproduce the issue, and I agree that it should be fixed.
As far as the implementation proposed above and in the merge request, I have two suggestions:
1. The change should go in
details.scssrather thanelements.scss2. I think that the addition of
display: list-item;should work for all browsers, so I'd prefer it to be a general declaration, rather than scoped only to@-moz-document url-prefix(). This should be verified in Chrome, Safari, and Edge, however.Comment #4
lreynaga commentedThank you for the input mark_fullmer.
I have undone the changes previously added and made the adjustment in the
details.scssfile and re-run thenode-sassscript.FWIW, I have verified the change is consistently being pulled in FF, Chrome and Safari, I am having issues while installing Edge on Mac, so I'll let reviewers cover that for me if possible. I'll keep trying to install and report back my findings there, but consistency so far makes me think it will work fine:
Comment #5
lreynaga commentedComment #7
mark_fullmerI checked this in MS Edge and confirmed that while the existing code is not problematic, the addition of
display:list-itemdoesn't introduce any regressions, and I still maintain that it's better to use that consistently across all browsers rather than scoping this to Firefox with@-moz-document url-prefix()Thanks for the fix!
Comment #8
mark_fullmer