Notices and warnings in layout_builder_modal_link_alter [#3160551]

After add or update the block (view listing, in particular) in a layout override getting such messages in the dblog:

Notice: Undefined index: class in layout_builder_modal_link_alter() (line 57 of /var/www/web/modules/contrib/layout_builder_modal/layout_builder_modal.module)
#0 /var/www/web/core/includes/bootstrap.inc(600): _drupal_error_handler_real(8, 'Undefined index...', '/var/www/web/mo...', 57, Array)
#1 /var/www/web/modules/contrib/layout_builder_modal/layout_builder_modal.module(57): _drupal_error_handler(8, 'Undefined index...', '/var/www/web/mo...', 57, Array)
.....

Warning: in_array() expects parameter 2 to be array, null given in layout_builder_modal_link_alter() (line 57 of /var/www/web/modules/contrib/layout_builder_modal/layout_builder_modal.module)
#0 /var/www/web/core/includes/bootstrap.inc(600): _drupal_error_handler_real(2, 'in_array() expe...', '/var/www/web/mo...', 57, Array)
#1 [internal function]: _drupal_error_handler(2, 'in_array() expe...', '/var/www/web/mo...', 57, Array)

The problem is that there are not enough checks in the above hook implementation.

Comment	File	Size	Author
#4	layout_builder_modal-fix-notices-and-warnings-3160551-4.patch	607 bytes	mark_fullmer
#2	layout_builder_modal-fix-notices-and-warnings-3160551.patch	612 bytes	NightHunterSV

Issue fork layout_builder_modal-3160551

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

About issue forks

Comments

Comment #1

21 July 2020 at 14:18

NightHunterSV created an issue. See original summary.

Comment #2

NightHunterSV commented 21 July 2020 at 14:25

Status	File	Size
new	layout_builder_modal-fix-notices-and-warnings-3160551.patch	612 bytes

Comment #3

NightHunterSV commented 21 July 2020 at 14:25

Assigned:	NightHunterSV	» Unassigned
Status:	Active	» Needs review

Comment #4

mark_fullmer

he/him

English

Tucson

commented 3 August 2020 at 15:37

Status	File	Size
new	layout_builder_modal-fix-notices-and-warnings-3160551-4.patch	607 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	layout_builder_modal-fix-notices-and-warnings-3160551.patch	612 bytes

The proposed array element check seems perfectly reasonable, given that the array element *must* be present (and must include use-ajax) for the modal behavior to proceed.

I'm curious, however, which links in the settings tray are triggering this behavior. This would be good to document inline.

Attached is a patch with the same check, but applies cleanly.

Comment #5

johnwebdev commented 4 August 2020 at 06:57

When would the class key not be an array though?

Comment #6

jeff cardwell commented 16 October 2020 at 17:26

Assigned:

Unassigned

» jeff cardwell

Comment #7

jeff cardwell commented 16 October 2020 at 21:25

The combination of the two messages above results from the class not being set at all, rather than the class key being set to something other than an array. I haven't been able to recreate that condition "naturally", but unsetting it in the hook (unset($variables['options']['attributes']['class']);) right before line 57 will cause that combination of messages.

If the class key is set to something other than an array, we do not see the "Notice: Undefined index" and only observe the "Warning: in_array() expects parameter 2 to be array, null given" message.