incompatibility with layout_builder_st, contextual links broken

Hi,

Thanks for the patch. It worked for me perfectly except for the theme option.

I have modified a little bit the code to work with this option.

Thanks for the issue!

I am wondering if we should widen the scope here and ensure any module can be compatible with Layout Builder Modal by allowing modules to alter the contextual links/routes that Layout Builder Modal should target instead.

Agreed that it would be better to broaden the scope, rather than committing a fix that is specific to Layout Builder ST, but I also think that it would be appropriate for Layout Builder Modal to maintain a list of known link keys & routes that it is compatible with.

It seems like the mechanism for altering the two new arrays should be through alter hooks (as opposed to a site-specific exposed UI for modifying the allowed link keys & form routes.

but I also think that it would be appropriate for Layout Builder Modal to maintain a list of known link keys & routes that it is compatible with.

Agreed!

For what it's worth, this is also incompatible with the core issue for layout translations on which Layout Builder ST is based: https://www.drupal.org/project/drupal/issues/2946333

Adding a patch that works with the core patch referenced above.

Patch #7 worked for me, thank you all

#7 on 9.1.0-rc1 works for me.

I have been using patch #7 now for about a year on two sites. Working great. Is there anything left needed for this development-wise to get it committed a new release cut?

RTBC +1.

Works good. Just minor code adjustments.

1. +++ b/layout_builder_modal.module
   @@ -9,22 +9,35 @@ use Drupal\Component\Serialization\Json;
   +  $links = $links;
   

   Odd line.

2. +++ b/layout_builder_modal.module
   @@ -77,11 +93,21 @@ function layout_builder_modal_link_alter(&$variables) {
   +  $applicable = false;
   

   To be consistent:
   true -> TRUE,
   false -> FALSE

I think something went wrong with the rerolls at some point. The patches are replacing the separate ajax class condition, but the first patches did not do that. I suspect that was added later and was accidently removed when resolving the conflict. New patch is just replacing the route condition.

Also addressed #12.

I'm really grateful for Patch #13! It fixed the issue with Layout Builder Modal in version 8.x-1.2 on Drupal v9.5.4 with PHP Version 8.1.2-1ubuntu2.11. Thank you, Drupal community! 🙌🏼

#13
3133695-13.patch
8.x-1.x: PHP 8.1 & MySQL 8.0, D9.5.9
This worked fine for me, thank you!

#13 3133695-13.patch

PHP Version 8.1.2
Drupal Version 9.5.9

Thank you very much for patch #13! Fixed issue with Layout Builder Modal.
Keep contributing, Drupal community!

PHP Version 8.1.21
Drupal Version 10.1.6

It is working fine.
Thank you very much for patch #13! Fixed issue with Layout Builder Modal.
Keep contributing, Drupal community!

The work on contextual links in this issue is related: https://www.drupal.org/project/layout_builder_modal/issues/3214458

I also confirm that #13 works in D10.3 + layout_builder_st alpha3 + layout_builder_modal 1.2