Problem/Motivation

After running the latest version of drupal-check on the module, it flagged the following issue:

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   layout_builder_additions/src/LayoutBuilderBlockFormTitle.php                                                                                      
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  85     Method Drupal\layout_builder_additions\LayoutBuilderBlockFormTitle::getLabelFromPluginId() should return string but return statement is missing.  
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

  • Run drupal-check against the module.

Proposed resolution

  • Fix the issue. A string should be returned no matter what.

Remaining tasks

Complete the work.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Comments

rklawson created an issue. See original summary.

  • rklawson committed d24d3db on 1.0.x
    Issue #3280785 by rklawson: Correct drupal-check issue.
    

  • rklawson committed 2d1b02a on 1.0.x
    Issue #3280785 by rklawson: Corrected coding standards violations.
    
rklawson’s picture

This has been resolved, and the 16 May 2022 at 20:57 CDT test has passed without coding standards violations:
https://www.drupal.org/pift-ci-job/2383393

rklawson’s picture

Status: Active » Fixed
rklawson’s picture

Status: Fixed » Closed (fixed)