Display of language names is not translated

I am afraid this module does not support translations yet.
I suppose we'll encounter the same problems as countries module .

I'm still not overly sold on the way that webflo done that there. But I've never done an i18n site and he is a co-maintainer for i18n... Personally I think providing the UI for translation only and wrapping everything in the t_countries(), or whatever I called it, would be the best way forward. But that is a completely different kettle of fish!

To the issue at hand.

/**
 * Helper function to generate the language options list.
 */
function languagefield_options($include_native = FALSE) {
  static $predefined = NULL, $predefined_with_native = NULL;
  if (!$predefined) {
    // @see _locale_prepare_predefined_list()
    require_once DRUPAL_ROOT . '/includes/iso.inc';
    $predefined = _locale_get_predefined_list();
    foreach ($predefined as $key => $value) {
      // Include native name in output, if possible
      $tname = t($value[0]);
      $predefined_with_native[$key] = $tname;
      $predefined[$key] = $tname;
      if (count($value) > 1) {
        $predefined_with_native[$key] = ($tname == $value[1]) ? $tname : "$tname ($value[1])";
      }
    }
    asort($predefined);
    asort($predefined_with_native);
  }
  return $include_native ? $predefined_with_native : $predefined;
}

This returns $tname = t($value[0]);, so the results of this should be being returned translated.
So the issue is with the load and that there is (almost) always field caching here.

/**
 * Implement hook_field_load().
 */
function languagefield_field_load($obj_type, $objects, $field, $instances, $langcode, &$items) {
  $languages = languagefield_options(FALSE);
  $languages_with_native = languagefield_options(FALSE);

  foreach ($objects as $id => $object) {
    foreach ($items[$id] as $delta => $item) {
      $items[$id][$delta]['safe_value'] = $languages[$item['value']];
      $items[$id][$delta]['safe_value_with_native'] = $languages_with_native[$item['value']];
    }
  }
}

This needs to be changed to a hook_field_prepare_view(). Completely untested first stab...

/**
 * Implements hook_field_prepare_view().
 */
function languagefield_field_prepare_view($entity_type, $entities, $field, $instances, $langcode, &$items) {
  $languages = languagefield_options(FALSE);
  $languages_with_native = languagefield_options(FALSE);
  foreach ($entities as $id => $entity) {
    foreach ($items[$id] as $delta => $item) {
      $items[$id][$delta]['safe_value'] = $languages[$item['value']];
      $items[$id][$delta]['safe_value_with_native'] = $languages_with_native[$item['value']];
    }
  }
}

And a update script that flushes the field caches (or a manual cache flush)

@johnv
Did you ever resolve that field non-caching thing?

@Alan,
IMO just using t(language) or t(country) seems to correct and straight-forward method, perhaps including a plain_text()-function.
PS. The countries-caching is still on my list. It reveiled some problems with other modules, too.

This is what we use here, but this is done too early, moving to pre_view should resolve most issues around this. As countries use user data too, rather than a predefined list here, it changes the scope / issues with i18n.

Patch should resolve these. Noticed what appeared to be another bug, so created three options to test this, name / name with native / (more for testing) native as display options.

Guess the RTL languages need work, but leaving that out of this patch.

Native formatter setting is going be a performance issue, this is dropped in this patch.

Right patch this time

@Alan, it seems like the patch is not made against lates 7.x-1.x git-code.

Patch #9 solves a caching problem. I am not sure how this helps OP's problem.

1. I have tested this in the following cases:
1. A.
- Enabled 'Translation'.
- Set user-language to 'nl' (Dutch)
- Create 3 nodes. Each with either 'und', 'en' or 'nl'
- Make sure a translation exists for the word 'Dutch' using module 'localization' (there was none in my system.)
- Show each node.
These are the restults:
- each node shows the user's translation of the field. This might be ok for 'und'-node. It is ok for 'nl'-node. But is it OK for 'en'-node. Shouldn't the translation be that of the node, instead of the user?

1.B.
- Enabled 'Translation, with field translation'. Enable 'field translation' for the language field.
On normal text field, I would get an option to change the value of the field. For the languagefield, I did not get this oppotunity,
so I could not test this further.

2. on some pages, e.g. the node edit page, hooks languagefield_field_load/languagefield_field_prepare_view are called with every possible language_code. The last one is the last one in the langage-list. Can this explain OP's "sometimes I have German language names" ?

A patch is coming up.

Please check out latest -dev-version.
I committed attached patch.
I get better results. I did not (yet) activate hook_field_prepare_view().

Just a heads up, I think load is too early for an i18n site as the results will be cached. Switching to preview means that these will be more responsive to the current language of site.

@Alan, I noticed. hook_field_load is loaded on every page, 1 time for every entity in the system. I guess more modules use this hook to often. I'll remove it in next commit.

I'me not sure what this discussion is all about. But I do know that the 7.x-1.x-dev version doesn't translate the languages, but the 7.x-1.0 version does! So, isn't the problem just in the dev-version?

Mike.

@john
"hook_field_load is loaded on every page" - i really must get a dump of your site to investigate this more. This is NOT normal behaviour!

@sportel
Yes, using load has resulted in the cached entity storing the translated values (these are not store in a language specific cache), thus my recommendation to use prepare view hook here.

sportel's #17 is right.
I committted this small patch, that should solve the issue.