I'm assuming there will still be a need for this module in Drupal 8. Would anyone care to help with the update?

CommentFileSizeAuthor
#5 label_help_d8-do-not-test.patch10.13 KBgnuget
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NWOM’s picture

NWOM CreditAttribution: NWOM commented

Having this in Drupal 8 would be incredibly helpful. I'll create an issue in the contrib tracker.

NWOM’s picture

NWOM CreditAttribution: NWOM commented

Contrib Tracker Issue created: #2798535: [label_help] Label Help

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented

I just needed this the last week for a D8 project, I will try to migrate it in the next week.

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
Status: Active » Needs review

I attach a patch in this issue and in this repo I will be sending my updates:

https://github.com/gnuget/label_help

This still needs work, needs manual testing (to check if all the field types are working as expected), and needs tests.

But at least is a functional version :-)

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
FileSize
label_help_d8-do-not-test.patch10.13 KB

Forgot to include the patch. x)

NWOM’s picture

NWOM CreditAttribution: NWOM commented

Great! I updated the Contrib Tracker issue.

Sheldon Rampton’s picture

Sheldon Rampton CreditAttribution: Sheldon Rampton commented
Status: Needs review » Fixed

@gnuget, thanks for your work on this. I wasn't able to get your patch to apply cleanly, so I cloned your github repo and used it to create a Drupal 8 branch for the module. I ran into an error during testing that was causing fatal errors when I tried to edit field configurations, so I added a quick fix to that. The module now works more or less, but I've noticed that the label help text doesn't appear above date fields, and I'm sure there are some other field types that are not working correctly yet either.

I'm going ahead and marking this issue fixed, since a Drupal 8 dev version now exists, even though it's not yet at the approved release stage. Hopefully people will start using it, and I'll get the feedback needed to improve it further.

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented

Hi!

Yes, using the module a found a few errors working with other elements so yes, this still needs a lot of work.

Thanks for your review and glad to help.

Hoping to give it another review soon and provide more patches.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 at Bluespark commented

I've created a followup issue that in theory should finalize the work needed to create a stable Drupal 8 release for Label Help.

Your review and testing are much appreciated.

#2948501: Improve Drupal 8 field compatibility

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 at Bluespark commented
Related issues: +#2948501: Improve Drupal 8 field compatibility