Fixed: l10n_update-codingstandards-2833046-2.patch

Hi!

Congrats on the module. He is excellent.

Just a few coding standards improvements for files:

Img

README.txt
l10n_update-translation-last-check.tpl.php
l10n_update-translation-update-info.tpl.php
l10n_update.admin.inc
l10n_update.api.php
l10n_update.batch.inc
l10n_update.bulk.inc
l10n_update.compare.inc
l10n_update.drush.inc
l10n_update.fetch.inc
l10n_update.http.inc
l10n_update.info
l10n_update.install
l10n_update.module
l10n_update.translation.inc
l10n_update.admin.js
l10n_update.admin.css
l10n_update.admin-rtl.css

Thanks.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

renatog created an issue. See original summary.

renatog’s picture

Assigned: renatog » Unassigned
Status: Active » Needs review
FileSize
28.31 KB
renatog’s picture

Issue summary: View changes
FileSize
38.56 KB
renatog’s picture

Issue summary: View changes
Sutharsan’s picture

Category: Bug report » Task
cebasqueira’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
91.85 KB

RTBC

Sutharsan’s picture

@renatog, what standards did you use?

renatog’s picture

Hi @sutharsan, how are you?

I used PHP_CodeSniffer with Standards for Drupal. (Version 7.x and 8.x)

I followed this tutorial: https://www.drupal.org/node/1419988

You can count on me.

Regards.

Sutharsan’s picture

I've made some changes:
- Removed the @codingStandardsIgnore*. Code style perfection is not my goal.
- Changed the README.txt line endings to be more human.
- Added empty lines in css file.
- some more.

Sutharsan’s picture

Status: Reviewed & tested by the community » Needs review
renatog’s picture

Status: Needs review » Reviewed & tested by the community

Ok @sutharsan.

It looks great.

Regards.

  • Sutharsan committed ebd2db5 on 7.x-2.x
    Issue #2833046 by renatog, Sutharsan, cebasqueira: Coding Standards
    
Sutharsan’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.