Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Fixed: l10n_update-codingstandards-2833046-2.patch
Hi!
Congrats on the module. He is excellent.
Just a few coding standards improvements for files:
README.txt
l10n_update-translation-last-check.tpl.php
l10n_update-translation-update-info.tpl.php
l10n_update.admin.inc
l10n_update.api.php
l10n_update.batch.inc
l10n_update.bulk.inc
l10n_update.compare.inc
l10n_update.drush.inc
l10n_update.fetch.inc
l10n_update.http.inc
l10n_update.info
l10n_update.install
l10n_update.module
l10n_update.translation.inc
l10n_update.admin.js
l10n_update.admin.css
l10n_update.admin-rtl.css
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff-2833046-2-9.txt | 7.7 KB | Sutharsan |
#9 | l10n_update-codingstandards-2833046-9.patch | 28.42 KB | Sutharsan |
#6 | screenshot-www.drupal.org-2016-12-05-10-35-06.png | 91.85 KB | cebasqueira |
#3 | 1) Img-33.png | 38.56 KB | renatog |
#2 | l10n_update-codingstandards-2833046-2.patch | 28.31 KB | renatog |
Comments
Comment #2
renatogComment #3
renatogComment #4
renatogComment #5
Sutharsan CreditAttribution: Sutharsan commentedComment #6
cebasqueira CreditAttribution: cebasqueira at CI&T commentedRTBC
Comment #7
Sutharsan CreditAttribution: Sutharsan commented@renatog, what standards did you use?
Comment #8
renatogHi @sutharsan, how are you?
I used PHP_CodeSniffer with Standards for Drupal. (Version 7.x and 8.x)
I followed this tutorial: https://www.drupal.org/node/1419988
You can count on me.
Regards.
Comment #9
Sutharsan CreditAttribution: Sutharsan as a volunteer commentedI've made some changes:
- Removed the @codingStandardsIgnore*. Code style perfection is not my goal.
- Changed the README.txt line endings to be more human.
- Added empty lines in css file.
- some more.
Comment #10
Sutharsan CreditAttribution: Sutharsan as a volunteer commentedComment #11
renatogOk @sutharsan.
It looks great.
Regards.
Comment #13
Sutharsan CreditAttribution: Sutharsan as a volunteer commented