Giving the l10n_client div the class "hidden" when it is not actually hidden but minimized is bad naming. This has lots of potential conflicts with other CSS, where hidden actually means hidden, i.e. "display:none" and/or "visibility:hidden". I recommend renaming this to "minimized" or something similar.

CommentFileSizeAuthor
#6 l10n_client-1181356-6.patch2.34 KBJody Lynn
#4 l10n_client-css_hidden.patch2.23 KBVolx
l10n_client-css_hidden.patch2.17 KBVolx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

afox’s picture

afox CreditAttribution: afox commented

+1 !

Tested working on the Feb 25th 6.x-2.x-dev

tsi’s picture

tsi CreditAttribution: tsi commented
Version: 6.x-2.0 » 7.x-1.0
Priority: Minor » Major

+2
HTML5 Boilerplate and many other css frameworks (including my 965 theme) use "hidden" to actually hide elements.
This makes this module unusable with any of these frameworks, so I believe this is major.

Jacine’s picture

Jacine
she/her
Location New York
CreditAttribution: Jacine commented

Just lost a couple of hours trying to figure this out as well. Can you please prefix the class name with the module name? I think .minimized is also too general.

Volx’s picture

Volx CreditAttribution: Volx commented
FileSize
l10n_client-css_hidden.patch2.23 KB

No problem, here it is with "l10-client-" prefix :)

tsi’s picture

tsi CreditAttribution: tsi commented
Status: Needs review » Reviewed & tested by the community

Tested against 7.x-1.1, solves the problem.
This should get committed.

Jody Lynn’s picture

Jody Lynn
she/her
Primary language English
CreditAttribution: Jody Lynn commented
FileSize
l10n_client-1181356-6.patch2.34 KB

Reroll.

Yes, I found this issue because my theme hid the translation link and I had to debug it.

gagarine’s picture

gagarine CreditAttribution: gagarine commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs work

Patch #6 add l10n-client-minimized but do not clean all hidden class..

EDIT I didn't say anythings.. I test it not on right branch.

gagarine’s picture

gagarine CreditAttribution: gagarine commented
Status: Needs work » Reviewed & tested by the community
SebCorbin’s picture

SebCorbin CreditAttribution: SebCorbin commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks !

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Does this apply to Drupal 6? For backport :)

SebCorbin’s picture

SebCorbin CreditAttribution: SebCorbin commented
Status: Fixed » Closed (fixed)

Yup, backported !