We have to convert the module to use short array as per new coding standard

CommentFileSizeAuthor
#3 key_array_search_results.png53.4 KBdhruveshdtripathi
#2 2875563-2.patch1.71 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
FileSize
2875563-2.patch1.71 KB

Applying the patch, please review.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Reviewed & tested by the community
FileSize
key_array_search_results.png53.4 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 9 array declarations, after applying patch there are 6. Those 6 array declarations are in_array and _convert_csv_to_array.

Good work!

  • rlhawk committed 05c4a59 on 8.x-1.x authored by Pavan B S 
    Issue #2875563 by Pavan B S, dhruveshdtripathi: Convert module to use...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
CreditAttribution: rlhawk commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.