Problem/Motivation

I have updated the module from 1.1.6 to 1.1.8, and after that I am having a WSOD in some pages.
The reason is a Exception not controlled in src/Service/KeepeekApiClient.php, the getToken() function.

The try/catch block only capture RequestException, but InvalidArgumentException is triggered when

$oauth_url = $config->get('account_service.oauth_url');

is NULL

Proposed resolution

We need to check the variable before the request

Issue fork keepeek-3608775

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dioni created an issue. See original summary.

dioni’s picture

Issue summary: View changes

dioni’s picture

Status: Active » Needs review
dioni’s picture

Assigned: dioni » Unassigned

Patched, MR created

dioni’s picture

Another issue has been found, it might be related

Uncaught TypeError: Cannot set properties of undefined (setting 'referrer')
    at video-player.js?tiw356:17:37
dioni’s picture

Updated MR with 2 changes:

1. js/video-player.js: I check the property statistics exists before assign href
2. KeepeekVideoPlayerFormatter: relies on default 'keepeek' theme if there is no video player configured.