Problem/Motivation

Project page points about wrong state about mysql support of json

Proposed resolution

Update code and project about mysql 5.7.8 json data type

Remaining tasks

Add mysql version check in install
update project page

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 2647512-1.patch4.8 KBkevinquillen
#9 2647512.patch5.47 KBkevinquillen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Assigned: Unassigned » kevinquillen
kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and commented
Status: Needs review » Active

no patch to review

mikl’s picture

mikl CreditAttribution: mikl as a volunteer commented

I've already implemented this on the 7.x-1.x branch, the code could probably be lifted from there :)

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented

Now that MySQL 5.7.7+ is available to most people from official distros, we can make some progress here.

I am going to rebuild my Drupal VM and see what we can move on here.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and commented

a kind of killswitch would be great to have a fallback to text-blob if mysql has no support

Also version should not be hard requirement to install the module

Suppose having message at reports/status is good

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented

I agree with that, is there any better way to signal to a user that the module isn't going to do a lot for them beyond the report page?

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
FileSize
2647512.patch5.47 KB

Here is an initial patch that addresses the version checking in the .install

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
FileSize
2647512-1.patch4.8 KB

Here is a better patch that simplifies things, since we just want to inform the user.

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Yes, that make more sense!

  • kevinquillen committed 94487b2 on 8.x-1.x 
    Issue #2647512 by kevinquillen: Add support for mysql 5.7.8
kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Status: Reviewed & tested by the community » Fixed
kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen at Velir commented
kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen at Velir commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.