Just because the 'serializer' service adds these container parameters as an API for modules to use doesn't mean our internal jsonapi serializer is required to follow suit.

CommentFileSizeAuthor
jsonapi-remove-container-parameters.patch855 byteseffulgentsia

Comments

effulgentsia created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Why add container parameters we instruct people to not use? » Clean-up:: stop creating container parameters for information that is no longer public
Status: Needs review » Reviewed & tested by the community
Issue tags: +API-First Initiative

Good find. It used to be a public API. This was part of that transition phase. We never got around to deleting it. Glad to see it gone!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Tests came back green 👍 Committed!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2923779: Normalizers violate NormalizerInterface, +#2936754: Avoid using the Serialization component for JSON API specific tasks

FWIW: this became irrelevant with #2923779: Normalizers violate NormalizerInterface and #2936754: Avoid using the Serialization component for JSON API specific tasks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.