Small refactoring to clean things up. See #2934730-26: Server error when accessing non-fieldable entity resources with filters.1

CommentFileSizeAuthor
#4 interdiff-3.txt544 bytesWim Leers
refactor-field-resolver-path-expansion.patch2.18 KBgabesullice
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gabesullice created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

The attempted patch in that other issue needed to call this logic, so it was refactored. It now looks like that patch won't continue to do that, but having this refactor still land totally makes sense!

+++ b/src/Context/FieldResolver.php
@@ -156,21 +156,36 @@ class FieldResolver {
+   * Expand the internal path with the "entity" keyword.

Nit: Expands. Will fix on commit.

  • Wim Leers committed 5094a2f on 8.x-1.x authored by gabesullice 
    Issue #2935430 by gabesullice: Refactor path expansion in FieldResolver
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Reviewed & tested by the community » Fixed
FileSize
interdiff-3.txt544 bytes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.