Closed (outdated)
Project:
JSON:API
Version:
8.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Oct 2017 at 13:32 UTC
Updated:
4 Jun 2018 at 16:29 UTC
Jump to comment: Most recent
This is a follow-up for #2874601-21: refactor(QueryBuilder): Improve testability/maintainability, where @e0ipso said:
2. I'd like to have a
AndConditionGroupandOrConditionGroupinstead ofEntityConditionGroupwhere we need to check for the->conjunction(). This doesn't need to be fixed here, but I'd like to see an issue linked here before merging so we don't forget.
Comments
Comment #2
gabesulliceComment #3
wim leers#2874601: refactor(QueryBuilder): Improve testability/maintainability has been committed :) Updated IS.
Comment #4
gabesulliceI think it's fair to postpone this. It's never been an issue and I also spent a little bit of time trying to do this yesterday, it really doesn't clean it up much and isn't as elegant as it sounds because PHP doesn't have union types.
Comment #5
wim leersThis is pure internal refactoring AFAICT.
Comment #6
gabesulliceCan't we just close this?
You can reopen if you disagree.