This is a follow-up for #2874601-21: refactor(QueryBuilder): Improve testability/maintainability, where @e0ipso said:

2. I'd like to have a AndConditionGroup and OrConditionGroup instead of EntityConditionGroup where we need to check for the ->conjunction(). This doesn't need to be fixed here, but I'd like to see an issue linked here before merging so we don't forget.

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

Issue summary: View changes
wim leers’s picture

gabesullice’s picture

Status: Active » Postponed

I think it's fair to postpone this. It's never been an issue and I also spent a little bit of time trying to do this yesterday, it really doesn't clean it up much and isn't as elegant as it sounds because PHP doesn't have union types.

wim leers’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev

This is pure internal refactoring AFAICT.

gabesullice’s picture

Priority: Normal » Minor
Status: Postponed » Closed (outdated)

Can't we just close this?

You can reopen if you disagree.