Problem/Motivation

Since we are outputting entities with UUIDs as the main JSON API identifier, we also need to support denormalizing payloads that contain UUIDs into entity classes.

Proposed resolution

Check the configuration for the ID key and use that to load the entity while deserializing in the RequestHandle.

CommentFileSizeAuthor
#25 2759707--support-denormalization-with-uuid--25.patch30.83 KBe0ipso
#21 2759707--support-denormalization-with-uuid--21.patch29.37 KBe0ipso
#16 2759707--support-denormalization-with-uuid--16.patch27.1 KBe0ipso
#15 2759707--support-denormalization-with-uuid--15.patch27.12 KBe0ipso
#8 2759707--support-denormalization-with-uuid--7.patch27 KBe0ipso
#7 2759707--support-denormalization-with-uuid--7--failing.patch24.06 KBe0ipso
#3 2759707-3.patch5.34 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

e0ipso created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Assigned: Unassigned » dawehner

Working on it

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
FileSize
2759707-3.patch5.34 KB

Needed to stop, will continue later. Maybe we though better patch core to support UUIDs in its entity_reference_item

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

#2790257: [FEATURE] Allow upserting entities with UUID references is a duplicate of this one.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Priority: Normal » Critical
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Assigned: dawehner » e0ipso

Stealing this from @dawehner.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Active » Needs review
FileSize
2759707--support-denormalization-with-uuid--7--failing.patch24.06 KB

Added failing patch.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
FileSize
2759707--support-denormalization-with-uuid--7.patch27 KB

Added fixing patch.

Even if this comes green we need error handling for situations where the user inputs unexisting UUIDs.

Status: Needs review » Needs work

The last submitted patch, 8: 2759707--support-denormalization-with-uuid--7.patch, failed testing.

The last submitted patch, 7: 2759707--support-denormalization-with-uuid--7--failing.patch, failed testing.

The last submitted patch, 8: 2759707--support-denormalization-with-uuid--7.patch, failed testing.

The last submitted patch, 7: 2759707--support-denormalization-with-uuid--7--failing.patch, failed testing.

The last submitted patch, 7: 2759707--support-denormalization-with-uuid--7--failing.patch, failed testing.

The last submitted patch, 7: 2759707--support-denormalization-with-uuid--7--failing.patch, failed testing.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs work » Needs review
FileSize
2759707--support-denormalization-with-uuid--15.patch27.12 KB

Forgotten annotation in abstract class.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
FileSize
2759707--support-denormalization-with-uuid--16.patch27.1 KB

Since I made it an abstract class, I should remove the group annotation.

The last submitted patch, 15: 2759707--support-denormalization-with-uuid--15.patch, failed testing.

The last submitted patch, 15: 2759707--support-denormalization-with-uuid--15.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 16: 2759707--support-denormalization-with-uuid--16.patch, failed testing.

The last submitted patch, 16: 2759707--support-denormalization-with-uuid--16.patch, failed testing.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
FileSize
2759707--support-denormalization-with-uuid--21.patch29.37 KB

Fixed other tests.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs work » Needs review

The last submitted patch, 3: 2759707-3.patch, failed testing.

The last submitted patch, 3: 2759707-3.patch, failed testing.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
FileSize
2759707--support-denormalization-with-uuid--25.patch30.83 KB

This completes this ticket by testing error cases.

  • dawehner committed 24e04df on 8.x-1.x authored by e0ipso 
    Issue #2759707 by e0ipso, dawehner: [FEATURE] Support denormalization...
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Fixed

This looks like a great feature and implementation, filters, maps etc. :)
Conceptually it'd be great to document this entire new code.

+++ b/src/Normalizer/DocumentRootNormalizer.php
@@ -74,9 +75,31 @@ class DocumentRootNormalizer extends NormalizerBase implements DenormalizerInter
+        list($entity_type_id,) = explode('--', $relationship['data'][0]['type']);

I really like using strtok for this specific usecase

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

@dawehner thank you for the review.

Conceptually it'd be great to document this entire new code.

Do you mean inline code documentation or more like drupal.org/documentation docs?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.