I think the root feed item should be an array instead of an object so we can filter out empty attributes.

CommentFileSizeAuthor
#11 use_array_instead_of-2885295-11.patch3.73 KBmarkdorison
#9 interdiff-8-9.txt613 bytesmarkdorison
#9 use_array_instead_of-2885295-9.patch4.48 KBmarkdorison
#8 feed_array-2885295-8.patch3.73 KBKarlShea
#6 feed_array-2885295-6.patch3.18 KBKarlShea
#4 feed_array-2885295-4.patch1.62 KBKarlShea
#2 feed_array-2885295-2.patch1.55 KBKarlShea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

KarlShea created an issue. See original summary.

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea at Weil Street Digital commented
Status: Active » Needs review
FileSize
feed_array-2885295-2.patch1.55 KB

Thoughts?

Status: Needs review » Needs work

The last submitted patch, 2: feed_array-2885295-2.patch, failed testing. View results

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea at Weil Street Digital commented
Status: Needs work » Needs review
FileSize
feed_array-2885295-4.patch1.62 KB

Look at that, the tests are useful already.

Status: Needs review » Needs work

The last submitted patch, 4: feed_array-2885295-4.patch, failed testing. View results

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea at Weil Street Digital commented
Status: Needs work » Needs review
FileSize
feed_array-2885295-6.patch3.18 KB

Update test view to add description value so description isn't stripped from output / Update test to check for description.

Status: Needs review » Needs work

The last submitted patch, 6: feed_array-2885295-6.patch, failed testing. View results

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea at Weil Street Digital commented
Status: Needs work » Needs review
FileSize
feed_array-2885295-8.patch3.73 KB

Update schema to add description.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
FileSize
use_array_instead_of-2885295-9.patch4.48 KB
interdiff-8-9.txt613 bytes

Fixed one code style issue.

@KarlShea Is there a benefit to building the JSON object as an array instead of an object?

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea at Weil Street Digital commented

The only reason was to use array_filter to remove empty attributes. It's possible that it wouldn't matter, but we're doing the same for feed items.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
FileSize
use_array_instead_of-2885295-11.patch3.73 KB

@KarlShea Works for me.

In the last patch I accidentally included the interdiff. Here is a fresh one.

  • markdorison committed fc6cd37 on 8.x-1.x authored by KarlShea 
    Issue #2885295 by KarlShea, markdorison: Use array instead of object to...
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.