Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hi!
Just a few coding standards improvements.
I hope to help.
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#4 | coding_standards-2841402-4.patch | 8.75 KB | gmaltoni |
#2 | coding_standards-2841402-2.patch | 13.2 KB | gmaltoni |
Comments
Comment #2
gmaltoni CreditAttribution: gmaltoni at CI&T commentedPatch with fixes.
Comment #3
markhalliwellDon't split these arrays out onto separate lines. It doesn't improve readability.
Don't change comment lengths, these are wrapped on 80 character width limits (per coding standards BTW).
Don't lowercase
MODULE_js_callback_CALLBACK
. The uppercaseMODULE
andCALLBACK
indicate the variable names based on those two parameters (e.g. likeHOOK
in other APIs).This is a variadic function. The ellipsis indicates that multiple parameters can be passed. Don't remove this.
Comment #4
gmaltoni CreditAttribution: gmaltoni at CI&T commentedHi @markcarver,
I've created a new patch to solve the topics pointed out in your comment.
Could you check this, please?
Best regards.
Comment #5
gmaltoni CreditAttribution: gmaltoni at CI&T commentedComment #7
markhalliwell