3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------------------------
Line jquery_carousel.module
------ ------------------------------------------------------------
129 PHPDoc tag @param references unknown parameter: $variables
------ ------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------------------
Line src/Plugin/Field/FieldFormatter/jCarouselFieldFormatter.php
------ ---------------------------------------------------------------------------------------------------------
67 Property Drupal\jquery_carousel\Plugin\Field\FieldFormatter\jCarouselFieldFormatter::$imageStyleStorage
(Drupal\image\ImageStyleStorageInterface) does not accept Drupal\Core\Entity\EntityStorageInterface.
74 Unsafe usage of new static().
💡 Consider making the class or the constructor final.
166 Access to an undefined property Drupal\Core\Entity\EntityInterface::$_referringItem.
------ ---------------------------------------------------------------------------------------------------------

[ERROR] Found 4 errors

CommentFileSizeAuthor
#3 3128805-3.patch4.04 KBgovind.maloo

Comments

piyuesh23 created an issue. See original summary.

govind.maloo’s picture

govind.maloo commented
Assigned: Unassigned » govind.maloo
govind.maloo’s picture

govind.maloo commented
StatusFileSize
new 3128805-3.patch4.04 KB

5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

piyuesh23’s picture

piyuesh23 commented
Status: Active » Reviewed & tested by the community

Patch looks good to me.

robbm’s picture

robbm commented

Upgrade Status seems to suggest an additional change is required to line 78 of web/modules/contrib/jquery_carousel/src/Plugin/Field/FieldFormatter/jCarouselFieldFormatter.php

Call to deprecated method getStorage() of class Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() instead.

(If I can work out exactly what that should look like before anyone else does so, I'll upload a new patch.)