Now that I got this module to work I'm facing problems when using it. I've created a simple view using the carousel plugin with just images from nodes and there are two issues:

1) Prev / Next links are not working. They are throwing the following error on the console of the browser: TypeError: page.first(...).position(...) is undefined at line 511:22 of file jquery.rs.carousel.js

2) When enabling touch, there are more errors and only if I install and enable jquery_update, those errors disappear. But the above still exists.

CommentFileSizeAuthor
#3 jquery_carousel-updating_doc_for_touch+fixing_container_width-2-7.x-1.x.patch1.78 KBpiyuesh23
#2 jquery_carousel-updating_doc_for_touch+fixing_container_width-2-7.x-1.x.patch4.69 KBpiyuesh23

Comments

piyuesh23’s picture

piyuesh23 commented
Issue tags: +SprintWeekend2016

@jurgenhaas,

Thanks for reporting & extremely sorry for the delayed response.

1) Prev / Next links are not working. They are throwing the following error on the console of the browser: TypeError: page.first(...).position(...) is undefined at line 511:22 of file jquery.rs.carousel.js

This was happening due to missing configuration for itemsPerTransition. Have set a default value for the same now.

2) When enabling touch, there are more errors and only if I install and enable jquery_update, those errors disappear. But the above still exists.

The touch mode for the library requires jquery v1.9. Will update readme & field's description.

piyuesh23’s picture

piyuesh23 commented
Status: Active » Needs review
StatusFileSize
new jquery_carousel-updating_doc_for_touch+fixing_container_width-2-7.x-1.x.patch4.69 KB

Uploading the patch here.

piyuesh23’s picture

piyuesh23 commented
StatusFileSize
new jquery_carousel-updating_doc_for_touch+fixing_container_width-2-7.x-1.x.patch1.78 KB

Uploaded the incorrect patch. Uploading the correct one now.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Version: 7.x-1.0 » 7.x-1.x-dev

correcting version

Re #1.2 We need a new followup for updating Read me & field's description.Please go ahead and file a new issue.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

@piyuesh23 thanks for your feedback. Unfortunately I currently don't have any project that's using this module, so I am not able to give it a test soon.

piyuesh23’s picture

piyuesh23 commented
Status: Needs review » Closed (fixed)

@Naveenalecha, Thanks for the review. The help text is already there in the patch above. Don't think we need a new issue here.

Will update the project description as well.

@jurgenhaas, No probs. Pushing it to 7.x-1.x-dev. You can test it whenever you find time.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Closed (fixed) » Fixed

#7
good.

  • naveenvalecha committed 7ee3064 on 8.x-1.x 
    Merge branch '8.x-1.x' of git.drupal.org:project/jquery_carousel into 8....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.