job_scheduler_rebuild_scheduler() is only called in one place. The $info param is passed in.

So there's no need at all for this:

function job_scheduler_rebuild_scheduler($name, $info = NULL) {
  $info = $info ? $info : job_scheduler_info($name);

It's only one line of code, but the calls to job_scheduler_info() everywhere make it really hard to understand the flow of the code. This will simplify things a lot.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

Status: Active » Needs review
FileSize
533 bytes
renatog’s picture

Assigned: Unassigned » renatog
Status: Needs review » Reviewed & tested by the community
Issue tags: +ciandt-contrib

Hi people.

I applied the patch and works good for me.

Good Catch. Thank you very much for contribution.

Regards

  • RenatoG committed 56ee60d on 7.x-2.x authored by joachim
    Issue #2180757 by joachim, RenatoG: make $info param to...
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Fixed.

Commited in dev branch.

Thanks.

Good Work and Good Weekend.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.