If a carousel View is returning a number of items less than the value set for 'visible' in the style options, empty placeholders are added by the jCarousel JS. We should limit visible to be never greater than the number of items returned from the Views query.

CommentFileSizeAuthor
#4 jcarousel-eternal_placeholders-1563776-2-D6-6.x-2.x.patch30.6 KBMike Lewis
#3 Screen Shot 2017-01-24 at 11.56.15 AM.png258.58 KBMike Lewis
#3 Screen Shot 2017-01-24 at 11.56.05 AM.png64.23 KBMike Lewis
#2 Screen Shot 2017-01-24 at 11.53.11 AM.png115.56 KBMike Lewis
#2 Screen Shot 2017-01-24 at 11.52.59 AM.png140.35 KBMike Lewis
#1 1433024.1-limit-visible.patch1.07 KBdeviantintegral
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

deviantintegral’s picture

deviantintegral CreditAttribution: deviantintegral commented
Status: Active » Needs review
FileSize
1433024.1-limit-visible.patch1.07 KB

This patch also works on 6.x-2.x.

Mike Lewis’s picture

Mike Lewis CreditAttribution: Mike Lewis commented
Issue summary: View changes
FileSize
Screen Shot 2017-01-24 at 11.52.59 AM.png140.35 KB
Screen Shot 2017-01-24 at 11.53.11 AM.png115.56 KB

I have a very similar problem in 6.x-2.6. I have a carousel with 10 images. If my screen resolution or browser zoom are such that more than 10 items can be displayed, then jCarousel creates placeholders for all slides to the right of the 10th slide. Then when it begins to scroll, each subsequent slide has an image. See the screen shots.

I applied the patch in #1 to no effect.

Mike Lewis’s picture

Mike Lewis CreditAttribution: Mike Lewis commented
FileSize
Screen Shot 2017-01-24 at 11.56.05 AM.png64.23 KB
Screen Shot 2017-01-24 at 11.56.15 AM.png258.58 KB

Here are my settings for the view.

Mike Lewis’s picture

Mike Lewis CreditAttribution: Mike Lewis commented
FileSize
jcarousel-eternal_placeholders-1563776-2-D6-6.x-2.x.patch30.6 KB

This solves my problem. Seems the this.first index of the first element in the carousel didn't get initialized when setting it up, so the placeholders never got replaced.

Hope this helps. This is for 6.x-2.x, so I don't know.

c2webdev’s picture

c2webdev CreditAttribution: c2webdev commented

I have the same issue, but all these patches are for 6, are there any for 7?